Skip to content

[rhel-9-main] Selinux test related backports #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zpetrace merged 8 commits into from
Dec 10, 2025
Merged

[rhel-9-main] Selinux test related backports #582

zpetrace merged 8 commits into from
Dec 10, 2025

Conversation

@pholica
Copy link
Contributor

@pholica pholica commented Dec 9, 2025 •
edited
Loading

@pholica pholica changed the title Selinux backports rhel 9 [rhel-9-main] Selinux test related backports Dec 9, 2025
@pholica pholica force-pushed the pholica-selinux-backports-rhel-9 branch from 5e8a24c to 7440ec4 Compare December 9, 2025 15:57
@pholica pholica requested review from pkoprda and zpetrace December 10, 2025 07:55
pkoprda
pkoprda previously approved these changes Dec 10, 2025
View reviewed changes
Copy link
Collaborator

@pkoprda pkoprda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zpetrace
zpetrace requested changes Dec 10, 2025
View reviewed changes
Copy link
Contributor

@zpetrace zpetrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, it seems some backports are missing as SELinux test is failing on the RHEL-9, please add the missing backports, thanks:)

@pholica
fix(testing framework): Do not change empty string to None
42a71b5 
Both are False, and there's no code that would distinguish between
empty string and None anyway. This makes it harder to use the
result of this function when working with it as with string.
@pholica
feat(testing framework): Add filtering of processes when getting AVCs…
ea0605c 
… as an argument
@pholica
test: insights-client running in unconfined_service_t context
7c01548 
Co-authored by black. I'm not responsible for formatting.
Refs: https://issues.redhat.com/browse/CCT-1718
@pholica
fix(test): Address SELinux incompatibility of testing
aa86671 
Some tests were not prepared for SELinux testing. Mostly, they are
testing command-line/tool related functionality rather than the "service"
mode of insights-client - being invoked by system timer or by other
services such as rhccc. Those test cases need to explicitly call
insights-client as a user would do not setting SELinux context.
@pholica
test: insights-client transitions to insights-core SELinux context
effff1c
@pholica pholica force-pushed the pholica-selinux-backports-rhel-9 branch from a1e8981 to effff1c Compare December 10, 2025 13:06
zpetrace
zpetrace approved these changes Dec 10, 2025
View reviewed changes
Copy link
Contributor

@zpetrace zpetrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@zpetrace zpetrace merged commit 522b8b9 into rhel-9-main Dec 10, 2025
9 of 10 checks passed
@zpetrace zpetrace deleted the pholica-selinux-backports-rhel-9 branch December 10, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zpetrace zpetrace zpetrace approved these changes

@pkoprda pkoprda pkoprda left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pholica @pkoprda @zpetrace