fix(test): Verify no egg-based content before every test #612
+12
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkoprda
force-pushed
the
pkoprda/fix-fixture-no-egg-files
branch
2 times, most recently
from
df03b7e to
7e7e3d6
Compare
pkoprda
force-pushed
the
pkoprda/fix-fixture-no-egg-files
branch
3 times, most recently
from
9d876a8 to
4b0e5c6
Compare
The fixture for checking that there is no egg-based content on the system was incorrect (it ran only once at the very beginning of the entire test run). This change fixes it so the fixture runs before every test.
The fixture check_no_egg_content() is currently checking if the /var/lib/insights does not have any file. This approach is incorrect since some commands create content in this directory (e.g. playbook verifier creates gpg files to verify the playbooks, host-details.json file is created in this directory by various tests). This commit updates it to check only for egg-based files.
pkoprda
force-pushed
the
pkoprda/fix-fixture-no-egg-files
branch
from
4b0e5c6 to
d5dd9ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fixture for checking that there is no egg-based content on the system was incorrect (it ran only once at the very beginning of the entire test run). This change fixes it so the fixture runs before every test.
This pull request should be also backported to following maintenance branches:
rhel-9-main(RHEL >= 9.8)