Skip to content

chore: remove deprecated pr_check.sh Jenkins GHPRB script (RHCLOUD-46…#302

Open
radekkaluzik wants to merge 1 commit intoRedHatInsights:masterfrom
radekkaluzik:RHCLOUD-46751
Open

chore: remove deprecated pr_check.sh Jenkins GHPRB script (RHCLOUD-46…#302
radekkaluzik wants to merge 1 commit intoRedHatInsights:masterfrom
radekkaluzik:RHCLOUD-46751

Conversation

@radekkaluzik
Copy link
Copy Markdown
Contributor

@radekkaluzik radekkaluzik commented Apr 30, 2026

…751)

Remove deprecated Jenkins GHPRB pr_check.sh script

The Jenkins job RedHatInsights-learning-resources-pr-check that used this
script has been removed as part of the GHPRB plugin deprecation initiative.

PR checks are now handled by:

  • Konflux (.tekton/learning-resources-pull-request.yaml)
  • GitHub Actions (.github/workflows/test.yml)

Related: RHCLOUD-46751


Anything reviewers should know?


Checklist

  • Accessibility: color contrast, keyboard nav, screen reader tested (or N/A)
  • All PR checks pass locally (build, lint, test)
  • No unrelated changes included
  • (Optional) QE: OUIA changed, test impact, no coverage
  • (Optional) UX: end-user UX modified, designs need sign-off

AI disclosure

@radekkaluzik radekkaluzik requested a review from a team April 30, 2026 14:03
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 4274bfc8-50ee-4e53-9da9-f9da7dcfc8fa

📥 Commits

Reviewing files that changed from the base of the PR and between 41309d7 and 514648b.

📒 Files selected for processing (2)
  • build_deploy.sh
  • pr_check.sh
💤 Files with no reviewable changes (2)
  • build_deploy.sh
  • pr_check.sh

Summary by CodeRabbit

  • Chores
    • Removed obsolete internal build and deployment helper scripts used by CI. These scripts previously exported build-related environment variables and produced placeholder test reports; their removal cleans up repository and CI configuration and does not change application runtime or any user-facing behavior.

Walkthrough

Two shell scripts, pr_check.sh and build_deploy.sh, were deleted; both previously exported frontend build/deploy environment variables, sourced a shared remote builder script, produced placeholder JUnit XML artifacts under the workspace, and propagated the sourced script’s exit status.

Changes

Cohort / File(s) Summary
Deleted CI/Build Scripts
pr_check.sh, build_deploy.sh
Removed scripts that exported component/image/workspace variables, sourced a remote/common builder (COMMON_BUILDER) to run frontend build/deploy logic, created placeholder JUnit XML reports in $WORKSPACE/artifacts, and exited with the sourced script’s exit code.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: removing deprecated Jenkins GHPRB scripts, which aligns with the changeset that deletes pr_check.sh and build_deploy.sh.
Description check ✅ Passed The description includes the required 2-3 sentence summary with context about why scripts are removed, an issue link, and a completed checklist, though Screenshots section is appropriately omitted for non-visual changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Review rate limit: 8/10 reviews remaining, refill in 7 minutes and 1 second.

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant