Skip to content

feat: add unique OUIA ID to feedback home title #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
catastrophe-brandon merged 1 commit into from
May 1, 2026
+5 −1
Merged

feat: add unique OUIA ID to feedback home title #306

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/components/HelpPanel/HelpPanelTabs/Feedback/FeedbackPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,11 @@ const FeedbackPanel: React.FC<SubTabProps> = ({ setNewActionTitle }) => {
<Stack hasGutter>
<StackItem>
<Content>
<Content component={ContentVariants.h1}>
<Content
component={ContentVariants.h1}
ouiaId="feedback-home-title"
ouiaSafe
>
{intl.formatMessage(messages.tellAboutExperience)}
</Content>
Comment on lines +133 to 139
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🌐 Web query:

Does the OUIA (OpenShift UI Automation) framework require both data-ouia-component-id and data-ouia-component-type attributes?

💡 Result:

Yes, the OUIA (Open UI Automation) framework requires both data-ouia-component-id and data-ouia-component-type attributes for components to be OUIA:Component compliant.

Citations:

🌐 Web query:

Does PatternFly React Content component support custom data attributes like data-ouia-component-id?

💡 Result:

Yes, the PatternFly React Content component supports custom data attributes like data-ouia-component-id. It explicitly provides ouiaId and ouiaSafe props that control data-ouia-component-id and data-ouia-safe attributes, respectively. PatternFly components generally forward additional props, including custom data-* attributes, to the rendered DOM element. The Content component is listed as OUIA-compliant in the official documentation.

Citations:

Add data-ouia-component-type attribute to achieve OUIA compliance.

The data-ouia-component-id attribute alone is insufficient. OUIA standards require both data-ouia-component-id and data-ouia-component-type for full OUIA:Component compliance. Add data-ouia-component-type="feedback-home-title" to the Content component, or use PatternFly's dedicated ouiaId prop as the preferred approach:

<Content
  component={ContentVariants.h1}
  ouiaId="feedback-home-title"
  ouiaComponentType="feedback-home-title"
>
  {intl.formatMessage(messages.tellAboutExperience)}
</Content>
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@src/components/HelpPanel/HelpPanelTabs/Feedback/FeedbackPanel.tsx` around
lines 133 - 138, The Content heading currently only sets data-ouia-component-id;
update the Content component in FeedbackPanel (the element rendering
intl.formatMessage(messages.tellAboutExperience)) to include the OUIA type as
well — either add data-ouia-component-type="feedback-home-title" alongside the
existing data-ouia-component-id or, preferably, use PatternFly's ouiaId and
ouiaComponentType props (ouiaId="feedback-home-title"
ouiaComponentType="feedback-home-title") on that Content element to achieve full
OUIA:Component compliance.

<Content component="p">
Expand Down
Loading