Bump storybook from 9.1.17 to 9.1.19#866
Open
dependabot[bot] wants to merge 1 commit intomasterfrom
Open
Conversation
dependabot
Bot
added
dependencies
dependabot
Bot
added
dependencies
Contributor
WalkthroughUpdated Storybook devDependency in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
package.json (1)
121-121: Version bump looks good, but consider aligning related Storybook packages.The security hardening for websocket connections in 9.1.19 is a worthwhile update. However, other
@storybook/*packages remain pinned to^9.1.17:
@storybook/addon-docs(line 55)@storybook/react-webpack5(line 57)eslint-plugin-storybook(line 97)While the
^prefix allows npm/yarn to resolve compatible versions, explicitly aligning these versions ensures consistency and avoids potential subtle incompatibilities during installation.🔧 Optional: Align all Storybook-related package versions
- "@storybook/addon-docs": "^9.1.17", + "@storybook/addon-docs": "^9.1.19", "@storybook/addon-webpack5-compiler-swc": "^3.0.0", - "@storybook/react-webpack5": "^9.1.17", + "@storybook/react-webpack5": "^9.1.19",- "eslint-plugin-storybook": "^9.1.17", + "eslint-plugin-storybook": "^9.1.19",🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@package.json` at line 121, Several Storybook-related dependencies are inconsistent: update `@storybook/addon-docs`, `@storybook/react-webpack5` and eslint-plugin-storybook to match the bumped storybook version (use ^9.1.19) so all `@storybook/`* packages are aligned; open package.json, locate the entries for "@storybook/addon-docs", "@storybook/react-webpack5" and "eslint-plugin-storybook" and change their version strings to "^9.1.19", then run your package manager install and test storybook start/build to verify no regressions.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@package.json`:
- Line 121: Several Storybook-related dependencies are inconsistent: update
`@storybook/addon-docs`, `@storybook/react-webpack5` and eslint-plugin-storybook to
match the bumped storybook version (use ^9.1.19) so all `@storybook/`* packages
are aligned; open package.json, locate the entries for "@storybook/addon-docs",
"@storybook/react-webpack5" and "eslint-plugin-storybook" and change their
version strings to "^9.1.19", then run your package manager install and test
storybook start/build to verify no regressions.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json
Contributor
|
/retest |
Bumps [storybook](https://github.com/storybookjs/storybook/tree/HEAD/code/core) from 9.1.17 to 9.1.19. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/v9.1.19/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v9.1.19/code/core) --- updated-dependencies: - dependency-name: storybook dependency-version: 9.1.19 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/storybook-9.1.19
branch
from
3a0f8ac to
8576f76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps storybook from 9.1.17 to 9.1.19.
Release notes
Sourced from storybook's releases.
Changelog
Sourced from storybook's changelog.
... (truncated)
Commits
20887f1Bump version from "9.1.18" to "9.1.19" [skip ci]66b2d8eFix test31f16c4fix linting62dd25bCore: Require token for websocket connectionsbbe61e3Bump version from "9.1.17" to "9.1.18" [skip ci]You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.