chore(deps): update module go.yaml.in/yaml/v2 to v3#103
chore(deps): update module go.yaml.in/yaml/v2 to v3#103red-hat-konflux[bot] wants to merge 1 commit intomasterfrom
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughUpdated Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
924f0ba to
5146c71
Compare
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
go.mod (1)
61-61:⚠️ Potential issue | 🔴 CriticalPR objective not accomplished: go.yaml.in/yaml/v2 was not updated to v3.
The PR claims to update
go.yaml.in/yaml/v2from v2.4.3 to v3.0.4, but the dependency graph confirmsgo.yaml.in/yaml/v2@v2.4.3remains unchanged. Nogo.yaml.in/yaml/v3exists in the dependency tree. The PR does not accomplish its stated objective.(Note:
gopkg.in/yaml.v3is a separate package and is already present; the PR appears to conflate these two different YAML packages.)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@go.mod` at line 61, The go.mod still lists "go.yaml.in/yaml/v2 v2.4.3" so the PR did not actually upgrade to v3; replace the v2 module requirement with the correct v3 module and update code imports accordingly by changing any import paths that reference "go.yaml.in/yaml/v2" to "go.yaml.in/yaml/v3" (and ensure you do NOT confuse this with "gopkg.in/yaml.v3" which is a different package); update the go.mod require line to reference go.yaml.in/yaml/v3@v3.0.4 (or run the equivalent go get) and run go mod tidy to refresh the dependency graph.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@go.mod`:
- Line 61: The go.mod still lists "go.yaml.in/yaml/v2 v2.4.3" so the PR did not
actually upgrade to v3; replace the v2 module requirement with the correct v3
module and update code imports accordingly by changing any import paths that
reference "go.yaml.in/yaml/v2" to "go.yaml.in/yaml/v3" (and ensure you do NOT
confuse this with "gopkg.in/yaml.v3" which is a different package); update the
go.mod require line to reference go.yaml.in/yaml/v3@v3.0.4 (or run the
equivalent go get) and run go mod tidy to refresh the dependency graph.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 9da08558-39b7-4fc1-98fd-6f7eca8fb46d
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
5146c71 to
37fa3e1
Compare
02d8638 to
11046c0
Compare
11046c0 to
b9c7221
Compare
b9c7221 to
53b6781
Compare
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
53b6781 to
cbcee82
Compare
This PR contains the following updates:
v2.4.3→v3.0.4Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Release Notes
yaml/go-yaml (go.yaml.in/yaml/v2)
v3.0.4Compare Source
v3.0.3Compare Source
v3.0.2Compare Source
v3.0.1Compare Source
v3.0.0Compare Source
v2.4.4Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.