chore(deps): update eslint monorepo to v10 (major)#134
chore(deps): update eslint monorepo to v10 (major)#134red-hat-konflux[bot] wants to merge 1 commit intomasterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Summary by CodeRabbit
WalkthroughBumped Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Review rate limit: 8/10 reviews remaining, refill in 6 minutes and 43 seconds. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@mcp/package.json`:
- Line 35: Update package.json dependencies to bump all typescript-eslint
packages to v8.56.0 or later by changing the versions for
`@typescript-eslint/typescript-estree`, `@typescript-eslint/eslint-plugin` (or
`@typescript-eslint/eslint-plugin` if named), and `@typescript-eslint/parser` to
^8.56.0 (or newer) so they are compatible with ESLint v10, and update the
engines.node entry from ">=20.0.0" to ">=20.19.0" to meet ESLint v10's Node
requirement; locate and modify the package.json dependency entries for the
`@typescript-eslint` packages and the "engines" -> "node" field to apply these
changes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: d6589fa6-e2c0-4140-935f-ac63445f5711
⛔ Files ignored due to path filters (1)
mcp/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
mcp/package.json
| }, | ||
| "devDependencies": { | ||
| "@eslint/js": "^9.17.0", | ||
| "@eslint/js": "^10.0.0", |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
Does typescript-eslint version 8.18.2 support ESLint version 10?
💡 Result:
No, typescript-eslint version 8.18.2 does not support ESLint version 10.
Citations:
- 1: https://typescript-eslint.io/users/dependency-versions
- 2: typescript-eslint/typescript-eslint@c60dbab
- 3: typescript-eslint/typescript-eslint@b2ce158
- 4: typescript-eslint/typescript-eslint@157b781
- 5: Enhancement: support eslint v10 typescript-eslint/typescript-eslint#11952
- 6: typescript-eslint/typescript-eslint@68a074f
🌐 Web query:
What are the minimum Node.js version requirements for ESLint version 10?
💡 Result:
The minimum Node.js version required for ESLint version 10 is v20.19.0. ESLint v10 supports Node.js ^20.19.0 || ^22.13.0 || >=24.
Citations:
- 1: https://eslint.org/blog/2025/10/whats-coming-in-eslint-10.0.0/
- 2: https://eslint.org/blog/2026/02/eslint-v10.0.0-released/
- 3: https://www.npmjs.com/package/eslint
- 4: https://eslint.org/docs/latest/use/migrate-to-10.0.0
🏁 Script executed:
#!/bin/bash
# Description: Check the actual typescript-eslint version constraints for ESLint compatibility
# Check package.json for typescript-eslint peer dependency requirements
cat mcp/package.json | jq -r '.devDependencies | to_entries[] | select(.key | contains("typescript-eslint") or contains("@typescript-eslint")) | "\(.key): \(.value)"'
# Check if there's a package-lock.json or yarn.lock that might reveal peer dependency warnings
fd -t f "package-lock.json|yarn.lock|pnpm-lock.yaml" mcp/Repository: RedHatInsights/widget-layout-backend
Length of output: 205
🌐 Web query:
What version of typescript-eslint supports ESLint version 10?
💡 Result:
typescript-eslint version 8.56.0 and later supports ESLint version 10. This is the first version where ESLint v10 support was added via PR #12057, as documented in the official changelog and release notes. All subsequent versions (8.56.1, 8.57.x, 8.58.x, etc.) continue to support it, with the peer dependency updated to include ^10.0.0 alongside ^8.57.0 and ^9.0.0.
Citations:
- 1: https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/typescript-eslint/CHANGELOG.md
- 2: https://github.com/typescript-eslint/typescript-eslint/blob/main/CHANGELOG.md
- 3: https://github.com/typescript-eslint/typescript-eslint/releases/tag/v8.56.0
- 4: https://github.com/typescript-eslint/typescript-eslint/releases/tag/v8.56.1
- 5: typescript-eslint/typescript-eslint@8b8b68f
- 6: typescript-eslint/typescript-eslint@v8.55.0...v8.56.0
- 7: typescript-eslint/typescript-eslint@68a074f
- 8: Enhancement: support eslint v10 typescript-eslint/typescript-eslint#11952
🌐 Web query:
typescript-eslint minimum version requirements for ESLint 10 compatibility
💡 Result:
The minimum version of typescript-eslint required for ESLint 10 compatibility is v8.0.0 or later, specifically versions like 8.57.0+ that include the peer dependency range "eslint": "^8.57.0 || ^9.0.0 || ^10.0.0". Prior versions only supported up to ESLint ^9.0.0 and would fail installation or runtime with ESLint 10 due to peer dependency mismatches and lack of flat config support.
Citations:
- 1: typescript-eslint/typescript-eslint@68a074f
- 2: https://typescript-eslint.io/users/dependency-versions
- 3: Enhancement: support eslint v10 typescript-eslint/typescript-eslint#11952
Upgrade typescript-eslint to v8.56.0+ and update Node.js requirement to >=20.19.0.
The ESLint v10 upgrade cannot proceed with the current dependencies:
-
typescript-eslint v8.18.2 is incompatible with ESLint v10. Support was added in v8.56.0. Upgrade
typescript-eslint,@typescript-eslint/eslint-plugin, and@typescript-eslint/parserfrom ^8.18.2 to ^8.56.0 or later. -
Node.js version requirement is insufficient. ESLint v10 requires Node.js ^20.19.0 (or ^22.13.0, or >=24), but package.json currently specifies >=20.0.0. Update line 51 to
"node": ">=20.19.0".
Also applies to: 41-41
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@mcp/package.json` at line 35, Update package.json dependencies to bump all
typescript-eslint packages to v8.56.0 or later by changing the versions for
`@typescript-eslint/typescript-estree`, `@typescript-eslint/eslint-plugin` (or
`@typescript-eslint/eslint-plugin` if named), and `@typescript-eslint/parser` to
^8.56.0 (or newer) so they are compatible with ESLint v10, and update the
engines.node entry from ">=20.0.0" to ">=20.19.0" to meet ESLint v10's Node
requirement; locate and modify the package.json dependency entries for the
`@typescript-eslint` packages and the "engines" -> "node" field to apply these
changes.
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
red-hat-konflux
Bot
force-pushed
the
konflux/mintmaker/master/major-eslint-monorepo
branch
from
e3319ec to
291051d
Compare
This PR contains the following updates:
^9.17.0→^10.0.0^9.17.0→^10.0.0Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Release Notes
eslint/eslint (@eslint/js)
v10.0.1Compare Source
Bug Fixes
c87d5bdfix: update eslint (#20531) (renovate[bot])d841001fix: updateminimatchto10.2.1to address security vulnerabilities (#20519) (루밀LuMir)04c2147fix: update error message for unused suppressions (#20496) (fnx)38b089cfix: update dependency @eslint/config-array to ^0.23.1 (#20484) (renovate[bot])Documentation
5b3dbcedocs: add AI acknowledgement section to templates (#20431) (루밀LuMir)6f23076docs: toggle nav in no-JS mode (#20476) (Tanuj Kanti)b69cfb3docs: Update README (GitHub Actions Bot)Chores
e5c281fchore: updates for v9.39.3 release (Jenkins)8c3832achore: update @typescript-eslint/parser to ^8.56.0 (#20514) (Milos Djermanovic)8330d23test: add tests for config-api (#20493) (Milos Djermanovic)37d6e91chore: remove eslint v10 prereleases from eslint-config-eslint deps (#20494) (Milos Djermanovic)da7cd0erefactor: cleanup error message templates (#20479) (Francesco Trotta)84fb885chore: package.json update for @eslint/js release (Jenkins)1f66734chore: addeslinttopeerDependenciesof@eslint/js(#20467) (Milos Djermanovic)v10.0.0Compare Source
Breaking Changes
f9e54f4feat!: estimate rule-tester failure location (#20420) (ST-DDT)a176319feat!: replacechalkwithstyleTextand addcolortoResultsMeta(#20227) (루밀LuMir)c7046e6feat!: enable JSX reference tracking (#20152) (Pixel998)fa31a60feat!: addnameto configs (#20015) (Kirk Waiblinger)3383e7efix!: remove deprecatedSourceCodemethods (#20137) (Pixel998)501abd0feat!: update dependency minimatch to v10 (#20246) (renovate[bot])ca4d3b4fix!: stricter rule tester assertions for valid test cases (#20125) (唯然)96512a6fix!: Remove deprecated rule context methods (#20086) (Nicholas C. Zakas)c69fdacfeat!: remove eslintrc support (#20037) (Francesco Trotta)208b5ccfeat!: UseScopeManager#addGlobals()(#20132) (Milos Djermanovic)a2ee188fix!: adduniqueItems: trueinno-invalid-regexpoption (#20155) (Tanuj Kanti)a89059dfeat!: Program range span entire source text (#20133) (Pixel998)39a6424fix!: assert 'text' is a string across all RuleFixer methods (#20082) (Pixel998)f28fbf8fix!: Deprecate"always"and"as-needed"options of theradixrule (#20223) (Milos Djermanovic)aa3fb2bfix!: tightenfunc-namesschema (#20119) (Pixel998)f6c0ed0feat!: reporteslint-envcomments as errors (#20128) (Francesco Trotta)4bf739ffix!: remove deprecatedLintMessage#nodeTypeandTestCaseError#type(#20096) (Pixel998)523c076feat!: drop support for jiti < 2.2.0 (#20016) (michael faith)454a292feat!: updateeslint:recommendedconfiguration (#20210) (Pixel998)4f880eefeat!: removev10_*and inactiveunstable_*flags (#20225) (sethamus)f18115cfeat!:no-shadow-restricted-namesreportglobalThisby default (#20027) (sethamus)c6358c3feat!: Require Node.js^20.19.0 || ^22.13.0 || >=24(#20160) (Milos Djermanovic)Features
bff9091feat: handleArray.fromAsyncinarray-callback-return(#20457) (Francesco Trotta)290c594feat: addselftono-implied-evalrule (#20468) (sethamus)43677defeat: fix handling of function and class expression names inno-shadow(#20432) (Milos Djermanovic)f0cafe5feat: rule tester add assertion optionrequireData(#20409) (fnx)f7ab693feat: output RuleTester test case failure index (#19976) (ST-DDT)7cbcbf9feat: addcountThisoption tomax-params(#20236) (Gerkin)f148a5efeat: add error assertion options (#20247) (ST-DDT)09e6654feat: update error loc ofrequire-yieldandno-useless-constructor(#20267) (Tanuj Kanti)Bug Fixes
436b82ffix: update eslint (#20473) (renovate[bot])1d29d22fix: detect defaultthisbinding inArray.fromAsynccallbacks (#20456) (Francesco Trotta)727451efix: fix regression of global mode report range instrictrule (#20462) (ntnyq)e80485ffix: remove fakeFlatESLintandLegacyESLintexports (#20460) (Francesco Trotta)9eeff3bfix: update esquery (#20423) (cryptnix)b34b938fix: useError.prepareStackTraceto estimate failing test location (#20436) (Francesco Trotta)51aab53fix: update eslint (#20443) (renovate[bot])23490b2fix: handle space before colon inRuleTesterlocation estimation (#20433) (Francesco Trotta)f244dbffix: useMessagePlaceholderDatatype from@eslint/core(#20348) (루밀LuMir)d186f8cfix: update eslint (#20427) (renovate[bot])2332262fix: error location should not modify error message in RuleTester (#20421) (Milos Djermanovic)ab99b21fix: ensurefilenameis passed as third argument toverifyAndFix()(#20405) (루밀LuMir)8a60f3bfix: removeecmaVersionandsourceTypefromParserOptionstype (#20415) (Pixel998)eafd727fix: removeTDZscope type (#20231) (jaymarvelz)39d1f51fix: correctScopetypings (#20404) (sethamus)2bd0f13fix: updateverifyandverifyAndFixtypes (#20384) (Francesco Trotta)ba6ebfafix: correct typings forloadESLint()andshouldUseFlatConfig()(#20393) (루밀LuMir)e7673aefix: correct RuleTester typings (#20105) (Pixel998)53e9522fix: strict removed formatters check (#20241) (ntnyq)b017f09fix: correctno-restricted-importmessages (#20374) (Francesco Trotta)Documentation
e978ddadocs: Update README (GitHub Actions Bot)4cecf83docs: Update README (GitHub Actions Bot)c79f0abdocs: Update README (GitHub Actions Bot)773c052docs: Update README (GitHub Actions Bot)f2962e4docs: documentmeta.docs.frozenproperty (#20475) (Pixel998)8e94f58docs: fix broken anchor links from gerund heading updates (#20449) (Copilot)1495654docs: Update README (GitHub Actions Bot)0b8ed5cdocs: document support for:isselector alias (#20454) (sethamus)1c4b33fdocs: Document policies about ESM-only dependencies (#20448) (Milos Djermanovic)3e5d38cdocs: add missing indentation space in rule example (#20446) (fnx)63a0c7cdocs: Update README (GitHub Actions Bot)65ed0c9docs: Update README (GitHub Actions Bot)b0e4717docs: [no-await-in-loop] Expand inapplicability (#20363) (Niklas Hambüchen)fca421fdocs: Update README (GitHub Actions Bot)d925c54docs: update config syntax inno-lone-blocks(#20413) (Pixel998)7d5c95fdocs: remove redundantsourceType: "module"from rule examples (#20412) (Pixel998)02e7e71docs: correct.mtsglob pattern in files with extensions example (#20403) (Ali Essalihi)264b981docs: Update README (GitHub Actions Bot)5a4324fdocs: clarify"local"option ofno-unused-vars(#20385) (Milos Djermanovic)e593aa0docs: improve clarity, grammar, and wording in documentation site README (#20370) (Aditya)3f5062edocs: Add messages property to rule meta documentation (#20361) (Sabya Sachi)9e5a5c2docs: removeExamplesheadings from rule docs (#20364) (Milos Djermanovic)194f488docs: Update README (GitHub Actions Bot)0f5a94adocs: [class-methods-use-this] explain purpose of rule (#20008) (Kirk Waiblinger)df5566fdocs: add Options section to all rule docs (#20296) (sethamus)adf7a2bdocs: no-unsafe-finally note for generator functions (#20330) (Tom Pereira)ef7028cdocs: Update README (GitHub Actions Bot)fbae5d1docs: consistently use "v10.0.0" in migration guide (#20328) (Pixel998)778aa2ddocs: ignoring default file patterns (#20312) (Tanuj Kanti)4b5dbcddocs: reorder v10 migration guide (#20315) (Milos Djermanovic)5d84a73docs: Update README (GitHub Actions Bot)37c8863docs: fix incorrect anchor link in v10 migration guide (#20299) (Pixel998)077ff02docs: add migrate-to-10.0.0 doc (#20143) (唯然)3822e1bdocs: Update README (GitHub Actions Bot)Build Related
9f08712Build: changelog update for 10.0.0-rc.2 (Jenkins)1e2c449Build: changelog update for 10.0.0-rc.1 (Jenkins)c4c72a8Build: changelog update for 10.0.0-rc.0 (Jenkins)7e4daf9Build: changelog update for 10.0.0-beta.0 (Jenkins)a126a2abuild: add .scss files entry to knip (#20389) (Francesco Trotta)f5c0193Build: changelog update for 10.0.0-alpha.1 (Jenkins)165326fBuild: changelog update for 10.0.0-alpha.0 (Jenkins)Chores
1ece282chore: ignore/docs/v9.xin link checker (#20452) (Milos Djermanovic)034e139ci: add type integration test for@html-eslint/eslint-plugin(#20345) (sethamus)f3fbc2fchore: set@eslint/jsversion to 10.0.0 to skip releasing it (#20466) (Milos Djermanovic)afc0681chore: remove scopeManager.addGlobals patch for typescript-eslint parser (#20461) (fnx)3e5a173refactor: use types from@eslint/plugin-kit(#20435) (Pixel998)11644b1ci: rename workflows (#20463) (Milos Djermanovic)2d14173chore: fix typos in docs and comments (#20458) (o-m12a)6742f92test: add endLine/endColumn to invalid test case in no-alert (#20441) (경하)3e22c82test: add missing location data to no-template-curly-in-string tests (#20440) (Haeun Kim)b4b3127chore: package.json update for @eslint/js release (Jenkins)f658419refactor: removerawparser option from JS language (#20416) (Pixel998)2c3efb7chore: removecategoryfrom type test fixtures (#20417) (Pixel998)36193fdchore: removecategoryfrom formatter test fixtures (#20418) (Pixel998)e8d203bchore: add JSX language tag validation tocheck-rule-examples(#20414) (Pixel998)bc465a1chore: pin dependencies (#20397) (renovate[bot])703f0f5test: replace deprecated rules inlintertests (#20406) (루밀LuMir)ba71baatest: enablestrictmode in type tests (#20398) (루밀LuMir)f9c4968refactor: removelib/linter/rules.js(#20399) (Francesco Trotta)6f1c48echore: updates for v9.39.2 release (Jenkins)54bf0a3ci: create package manager test (#20392) (루밀LuMir)3115021refactor: simplify JSDoc comment detection logic (#20360) (Pixel998)4345b17chore: update@eslint-community/regexppto4.12.2(#20366) (루밀LuMir)772c9eechore: update dependency @eslint/eslintrc to ^3.3.3 (#20359) (renovate[bot])0b14059chore: package.json update for @eslint/js release (Jenkins)d6e7bf3ci: bump actions/checkout from 5 to 6 (#20350) (dependabot[bot])139d456chore: require mandatory headers in rule docs (#20347) (Milos Djermanovic)3b0289cchore: remove unused.eslintignoreand test fixtures (#20316) (Pixel998)a463e7bchore: update dependency js-yaml to v4 [security] (#20319) (renovate[bot])ebfe905chore: remove redundant rules from eslint-config-eslint (#20327) (Milos Djermanovic)88dfdb2test: add regression tests for message placeholder interpolation (#20318) (fnx)6ed0f75chore: skip type checking ineslint-config-eslint(#20323) (Francesco Trotta)1e2cad5chore: package.json update for @eslint/js release (Jenkins)9da2679chore: update@eslint/*dependencies (#20321) (Milos Djermanovic)0439794refactor: use types from @eslint/core (#20235) (jaymarvelz)cb51ec2test: cleanupSourceCode#traversetests (#20289) (Milos Djermanovic)897a347chore: remove restriction fortypein rule tests (#20305) (Pixel998)d972098chore: ignore prettier updates in renovate to keep in sync with trunk (#20304) (Pixel998)a086359chore: remove redundantfast-globdev-dependency (#20301) (루밀LuMir)564b302chore: installprettieras a dev dependency (#20302) (michael faith)8257b57refactor: correct regex foreslint-plugin/report-message-format(#20300) (루밀LuMir)e251671refactor: extract assertions in RuleTester (#20135) (唯然)2e7f25echore: addlegacy-peer-depsto.npmrc(#20281) (Milos Djermanovic)39c638achore: update eslint-config-eslint dependencies for v10 prereleases (#20278) (Milos Djermanovic)8533b3fchore: update dependency @eslint/json to ^0.14.0 (#20288) (renovate[bot])796ddf6chore: update dependency @eslint/js to ^9.39.1 (#20285) (renovate[bot])Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.