Skip to content

chore(deps): update module github.com/pioz/faker to v2 #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
red-hat-konflux wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(deps): update module github.com/pioz/faker to v2 #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ require (
golang.org/x/text v0.33.0 // indirect
golang.org/x/tools v0.41.0 // indirect
google.golang.org/protobuf v1.36.11 // indirect
gopkg.in/yaml.v3 v3.0.1 // indirect
gopkg.in/yaml.v2 v2.4.0 // indirect
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# 1) Show faker entries in module files
rg -n -C2 'github.com/pioz/faker(/v2)?' go.mod go.sum || true

# 2) Show faker import paths in Go sources
rg -n -C2 '"github.com/pioz/faker(/v2)?"' --type go || true

# 3) Show YAML-related entries to confirm this PR's effective change
rg -n -C1 'gopkg.in/yaml.v2|gopkg.in/yaml.v3|go.yaml.in/yaml/v2' go.mod go.sum || true

Repository: RedHatInsights/widget-layout-backend

Length of output: 2893

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Check git log and commit messages for context
git log --oneline -5 2>/dev/null || echo "Git history unavailable"

# Check if there's a PR description or branch name that indicates intent
git branch -a 2>/dev/null | head -20 || true

# Look at the actual diff for go.mod to see what changed
git diff HEAD~1 go.mod 2>/dev/null || echo "No git diff available"

Repository: RedHatInsights/widget-layout-backend

Length of output: 268

Incomplete faker v2 upgrade: go.mod still pins v1.

The commit message indicates this should upgrade github.com/pioz/faker to v2, but go.mod line 50 still shows v1.7.3 // indirect, and no /v2 import paths were found in code. For a v2 major upgrade, Go requires module path migration to /v2. Either the upgrade is incomplete or the commit message is misleading.

The YAML dependency update (line 69) appears unrelated to this objective.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@go.mod` at line 69, The go.mod still references the old faker module version
"github.com/pioz/faker v1.7.3 // indirect" while the commit message claims a v2
upgrade; to fix, decide whether you truly intend to upgrade to v2 and if so
update imports and module path to "github.com/pioz/faker/v2" across the
codebase, run `go get github.com/pioz/faker/v2@latest` and `go mod tidy` to
update go.mod and go.sum, and then replace any remaining import lines
referencing "github.com/pioz/faker" to the new "/v2" path (or if you do not
intend to upgrade, adjust the commit message to remove the v2 claim); use the
module name "github.com/pioz/faker" and the new "github.com/pioz/faker/v2"
import to locate and update the code.

gopkg.in/yaml.v3 v3.0.1 // indirect
gorm.io/driver/mysql v1.6.0 // indirect
)