Merged
Conversation
ajGingrich
force-pushed
the
gti-251
branch
5 times, most recently
from
5aa86ba to
df89af6
Compare
ajGingrich
requested review from
kurtfm,
mar1boroman,
sagile and
thomasefthymiou78
as code owners
There have been instances of blank spreadsheets output. It's not clear why so this logging allows for better debugging.
ajGingrich
commented
Jul 29, 2025
| # For each service account found try to fetch the clusters metrics using the | ||
| # google cloud monitoring api metrics | ||
| for service_account in service_accounts: | ||
| project_id, stats = project_id, stats = process_google_service_account( |
Contributor
Author
There was a problem hiding this comment.
It looks like this duplicate got destructuring was introduced recently here and can be removed.
thomasefthymiou78
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There have been instances of blank spreadsheets output.
The reason is not clear, so this logging allows for better debugging.