Add --user-account option#20
Merged
ajGingrich merged 7 commits intoRedislabs-Solution-Architects:mainfrom Aug 21, 2025
Merged
Conversation
frivoire
requested review from
ajGingrich,
kurtfm,
mar1boroman,
sagile and
thomasefthymiou78
as code owners
ajGingrich
reviewed
Aug 6, 2025
Contributor
ajGingrich
left a comment
ajGingrich
left a comment
There was a problem hiding this comment.
Overall I like it. Can you run the formatting with black .?
Co-authored-by: Andrew Gingrich <gandrew320@gmail.com>
Contributor
|
@frivoire are waiting on anything or should we be good to go ahead and merge these in? |
Contributor
Author
I'm not waiting on anything : the patch works when I tested it, so ok for me. |
Contributor
|
@frivoire Sounds good, I wasn't sure if you didn't have permissions to merge. I'm merging now! |
ajGingrich
merged commit 10263bc
into
Redislabs-Solution-Architects:main
6 checks passed
Contributor
Author
No, I don't have permission to merge here, I'm just a random guy, not a Redis employee. |
Contributor
|
@frivoire I see that now, I forgot these were open but makes sense. Thanks for contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why ?
When a local GCP account (usually a user-account) already has access to the Memorystore instances of one/several GCP projects, it's much simpler to use that user-account than creating/getting the keys of one/several service-account(s).
Fixing #3
Proposed fix
Patch the script so that we can run it without any service-account files provided, example:
And of course: no change to the default behavior (=> it will continue using the provided service-account)
NB: the real diff are small, cf the "hide whitespace option", it's mostly reindent ;)