added support for Valkey and Redis Cluster instances#22
Merged
thomasefthymiou78 merged 2 commits intoRedislabs-Solution-Architects:mainfrom Sep 26, 2025
Merged
Conversation
denisabrantesredis
requested review from
ajGingrich,
kurtfm,
mar1boroman,
sagile and
thomasefthymiou78
as code owners
ajGingrich
reviewed
Sep 25, 2025
|
|
||
| echo "$projects" | while read -r project_id; do | ||
| python msstats.py -p $project_id | ||
| python memorystore.py --project $project_id --credentials /path/to/sa.json --out /path/to/$project_id.csv |
Contributor
There was a problem hiding this comment.
Can we create a separate batch script for the memory store script?
ajGingrich
reviewed
Sep 25, 2025
Contributor
ajGingrich
left a comment
ajGingrich
left a comment
There was a problem hiding this comment.
Could you run the formatting black *.py. We need that to pass CI before merging
| ``` | ||
| # To use the copied service-account: | ||
| python msstats.py | ||
| python memorystore.py --project YOUR_PROJECT_ID --credentials /path/to/sa.json --out /path/to/out.csv |
Contributor
There was a problem hiding this comment.
can you make a separate section with a short explanation of the new memorystore script?
thomasefthymiou78
approved these changes
Sep 26, 2025
thomasefthymiou78
merged commit 071e5b5
into
Redislabs-Solution-Architects:main
6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.