Recreate package-lock & sort package.json#166
Open
Saibamen wants to merge 1 commit intoRegnology:masterfrom
Open
Recreate package-lock & sort package.json#166Saibamen wants to merge 1 commit intoRegnology:masterfrom
Saibamen wants to merge 1 commit intoRegnology:masterfrom
Conversation
Arsenicro
reviewed
Oct 14, 2022
Contributor
Arsenicro
left a comment
There was a problem hiding this comment.
The bad news is that it seems to be breaking our app: I see multiple errors when running it (Element type is invalid and process is not defined and so on).
The good news is that I think I know why: in the index.js file, we are using ReactNotification from the react-notifications-component, which weirdly does not exists (maybe it existed in previous versions). Instead, we should use named ReactNotifications.
Also, it seems like running npm install still changes package-lock a bit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
package-lock.jsonby deleting this file andnode_modulesfolder and runningnpm installagainnpx sort-package-json