Conversation
Contributor
|
approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes may require removing the old
node-modulesfolder and runningnpm installagain.react-scripts- use default imports instead of named ones to import scss files (the new version ofreact-scriptsdoes not support it)react-bootstrap- for some reason new version does not see styles while testing, so instead of checking if the dropdown is visible, we will check if it has the classshow.react-notification- the way we should import it is different nowreduxanduuidThe rest of the upgraded libraries did not require any changes.
With these changes, we have only 6 libraries without the newest version.
axios, because version 1.0 does not seem stable yetreactandreact-dombecause ofreact-month-picker(and maybe something more, we have to check it)*
react-notifications-componentand@testing-library/react- because they require react 18react-router-dom- because the new react-router is somewhat different, there will be more changes that need to be done to upgrade it