Allow moving filepaths #22
Closed
+103
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vustef
commented
Dec 8, 2025
| inner: Arc<Storage>, | ||
|
|
||
| /// Cached operator to reuse for all operations. | ||
| /// When present, this operator will be used instead of calling create_operator. |
gbrgr
reviewed
Dec 9, 2025
| &self, | ||
| path: &'a impl AsRef<str>, | ||
| ) -> Result<(Operator, &'a str)> { | ||
| let (op, relative_path) = self.inner.create_operator(path)?; |
Collaborator
There was a problem hiding this comment.
Why do we create the operator even when there's a cached one? Shouldn't this go into the else?
Author
There was a problem hiding this comment.
So that it can resolve relative path. It's hacky, I'll pause on this for now. I don't like that we have to specify what we're translating from, seems to me that the code should be detecting that...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow moving file-paths by specifying cached OpenDAL operator. This operator is used to as a "target" operator in this move. The FileIO should be built using the scheme of the source operator. E.g. if paths are S3 paths, but are moved to local file system, "target" should be LocalFS operator, while scheme should be "s3". See test_file_io_with_cached_operator for an example