Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/1f23tBM3/19439-recurring-task-development-webcomponents-check-package-dependencies
Summary
packages/web-components, including@microsoft/api-extractorto^7.57.7,@rollup/plugin-commonjsto^29.0.2,@rollup/plugin-terserto^1.0.0,@typescript-eslint/eslint-pluginand@typescript-eslint/parserto^8.57.1,rollupto^4.59.0, andviteto^8.0.0@lit/context(>=1.1.6 <2.0.0) andlit(>=3.3.1 <4.0.0)eslinton the latest compatible9.xrelease (^9.39.4) because currenteslint-plugin-importandeslint-plugin-promisepeer ranges do not yet accepteslint@10Validation
npm run build(inpackages/web-components): passednpm run build:types(inpackages/web-components): passednpm run test(inpackages/web-components): fails intests/popular-products.test.tsagainst live Relewise API data; 20 tests passed and 1 integration test failed in each browserNotes
npm outdatedstill reportseslint@10.0.3as latest, but that major cannot be adopted yet without breaking the current ESLint plugin peer graphnpm outdatedalso reports peer dependency@relewise/client@2.23.1as latest; it was not upgraded because the workflow only updates directdependenciesanddevDependencies