Bug: Prevent empty pagination requests in feed API#3023
Open
nicktytarenko wants to merge 2 commits intomainfrom
Open
Bug: Prevent empty pagination requests in feed API#3023nicktytarenko wants to merge 2 commits intomainfrom
nicktytarenko wants to merge 2 commits intomainfrom
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3023 +/- ##
=======================================
Coverage 76.69% 76.69%
=======================================
Files 550 550
Lines 29508 29509 +1
=======================================
+ Hits 22632 22633 +1
Misses 6876 6876 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
koutst
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



ResearchHub/issues#684
What?
The feed API endpoint (
/api/feed/) was returning anextpagination link even when there were no more items to fetch. This caused the frontend to make unnecessary API requests to empty pages.Example:
api/feed/?page=1&page_size=20&feed_view=popular&hub_slug=biologynextpointing topage=2page=2which returns empty resultsSolution
Updated
FeedPagination.get_paginated_response()to only include thenextlink when the number of results equals the requested page size. This ensures:next(more pages may exist)next(no more pages)