Skip to content

[expert-finder] 4 - list, create, and detail API#3404

Merged
nicktytarenko merged 11 commits intomainfrom
expert-finder-v2/v2-view-tests
May 7, 2026
Merged

[expert-finder] 4 - list, create, and detail API#3404
nicktytarenko merged 11 commits intomainfrom
expert-finder-v2/v2-view-tests

Conversation

@nicktytarenko
Copy link
Copy Markdown
Contributor

What?

  • Adds v2 endpoints under expert-finder/v2/searches/ for listing, creating , and fetching detail with a new shape.
  • Introduces v2 serializers
  • Wires Celery to run_expert_finder_search_v2 so new searches use a new pipeline and v2 prompts.

- Introduced ExpertSearchCreateSerializerV2 for creating expert searches with additional fields and validation.
- Added ExpertSearchDetailSerializerV2 and ExpertSearchListItemSerializerV2 for detailed and list representations of expert searches.
- Implemented ExpertSearchListCreateViewV2 to handle GET and POST requests for expert searches.
- Updated URLs to include new v2 endpoints for expert searches.
- Enhanced tests for the new serializers and views to ensure proper functionality and validation.
@nicktytarenko nicktytarenko requested a review from a team as a code owner May 3, 2026 20:19
@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

- Introduces PATCH `/api/research_ai/expert-finder/v2/experts/<expert_id>/` so editors/moderators can correct expert contact and profile fields after a v2 search.
[expert-finder] 8 - One-time backfill from expert_results JSON to Expert
…v2-signup-async

[expert-finder] 7 - async signup signal to store as invited
…2-email-send-metadata

[expert-finder] 6 - `generate-email` v2 endpoints
[expert-finder] 5 - Add v2 PATCH endpoint for expert records
Base automatically changed from expert-finder-v2/json-llm-service-and-task to main May 7, 2026 19:01
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 7, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
6.8% Duplication on New Code (required ≤ 5%)

See analysis details on SonarQube Cloud

@nicktytarenko nicktytarenko merged commit 78d4adc into main May 7, 2026
3 of 4 checks passed
@nicktytarenko nicktytarenko deleted the expert-finder-v2/v2-view-tests branch May 7, 2026 19:21
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

❌ Patch coverage is 91.33192% with 41 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.62%. Comparing base (a3ebeef) to head (fca6cb5).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
src/research_ai/views/email_views_v2.py 82.35% 12 Missing ⚠️
...rch_ai/services/expert_results_legacy_migration.py 92.55% 7 Missing ⚠️
src/research_ai/serializers.py 94.91% 6 Missing ⚠️
src/research_ai/views/expert_finder_views_v2.py 93.47% 6 Missing ⚠️
...ement/commands/migrate_expert_results_to_models.py 91.48% 4 Missing ⚠️
...rc/research_ai/services/invited_experts_service.py 87.50% 3 Missing ⚠️
src/research_ai/tasks.py 72.72% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3404      +/-   ##
==========================================
+ Coverage   79.47%   79.62%   +0.14%     
==========================================
  Files         643      648       +5     
  Lines       37635    38088     +453     
==========================================
+ Hits        29910    30327     +417     
- Misses       7725     7761      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants