Skip to content

Use logging in Amplitude webhook#3414

Open
gzurowski wants to merge 2 commits intomainfrom
amplitude-logging
Open

Use logging in Amplitude webhook#3414
gzurowski wants to merge 2 commits intomainfrom
amplitude-logging

Conversation

@gzurowski
Copy link
Copy Markdown
Member

  • Use logger instead of Sentry utils (error-level logs are automatically be pushed to Sentry).
  • Don't reveal exception to caller (Amplitude).

@gzurowski gzurowski requested a review from a team as a code owner May 5, 2026 07:55
@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 5, 2026

@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.43%. Comparing base (dd41a3c) to head (0e74ee2).

Files with missing lines Patch % Lines
src/analytics/views/amplitude_webhook_view.py 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3414      +/-   ##
==========================================
- Coverage   79.43%   79.43%   -0.01%     
==========================================
  Files         638      638              
  Lines       37107    37105       -2     
==========================================
- Hits        29476    29473       -3     
- Misses       7631     7632       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@yattias yattias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants