Some refactorings / notes

Banane9 · Banane9 · commit 64641ec55462 · 2025-06-03T09:17:48.000+02:00
diff --git a/CommunityBugFixCollection/BreakDragAndDropCopiedComponentDrives.cs b/CommunityBugFixCollection/BreakDragAndDropCopiedComponentDrives.cs
@@ -22,6 +22,7 @@ protected override bool OnEngineReady()
             var integrationMod = Mod.Loader.Get<Mod>().ById("MonkeyLoader.GamePacks.Resonite");
 
             // Newer version than last one that did not include the fix
+            // accidentally not included in 0.23.0 ...
             if (integrationMod is not null && integrationMod.Version > new NuGetVersion(0, 22, 1))
             {
                 Logger.Info(() => "Skipping in favor of the Resonite Integration fix.");
diff --git a/CommunityBugFixCollection/ColorDisplayValueProxy.cs b/CommunityBugFixCollection/ColorDisplayValueProxy.cs
@@ -9,6 +9,7 @@
 
 namespace CommunityBugFixCollection
 {
+    // Todo: do this for strings and objects too?
     [HarmonyPatchCategory(nameof(ColorDisplayValueProxy))]
     [HarmonyPatch(typeof(ValueDisplay<color>), nameof(ValueDisplay<color>.BuildContentUI))]
     internal sealed class ColorDisplayValueProxy : ResoniteBugFixMonkey<ColorDisplayValueProxy>
diff --git a/CommunityBugFixCollection/ValidQuaternionInputs.cs b/CommunityBugFixCollection/ValidQuaternionInputs.cs
@@ -20,8 +20,6 @@ private static void Postfix(ProtoFluxNode __result)
             if (!Enabled)
                 return;
 
-            Logger.Info(() => $"__result is: {__result.GetType().CompactDescription()}");
-
             __result.RunInUpdates(0, () =>
             {
                 if (__result is ValueInput<floatQ> floatQInput)

Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,7 @@ protected override bool OnEngineReady()`
`22`	`22`	`var integrationMod = Mod.Loader.Get<Mod>().ById("MonkeyLoader.GamePacks.Resonite");`
`23`	`23`
`24`	`24`	`// Newer version than last one that did not include the fix`
	`25`	`+ // accidentally not included in 0.23.0 ...`
`25`	`26`	`if (integrationMod is not null && integrationMod.Version > new NuGetVersion(0, 22, 1))`
`26`	`27`	`{`
`27`	`28`	`Logger.Info(() => "Skipping in favor of the Resonite Integration fix.");`
Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,7 @@`
`9`	`9`
`10`	`10`	`namespace CommunityBugFixCollection`
`11`	`11`	`{`
	`12`	`+ // Todo: do this for strings and objects too?`
`12`	`13`	`[HarmonyPatchCategory(nameof(ColorDisplayValueProxy))]`
`13`	`14`	`[HarmonyPatch(typeof(ValueDisplay<color>), nameof(ValueDisplay<color>.BuildContentUI))]`
`14`	`15`	`internal sealed class ColorDisplayValueProxy : ResoniteBugFixMonkey<ColorDisplayValueProxy>`
Original file line number	Diff line number	Diff line change
`@@ -20,8 +20,6 @@ private static void Postfix(ProtoFluxNode __result)`
`20`	`20`	`if (!Enabled)`
`21`	`21`	`return;`
`22`	`22`
`23`		`- Logger.Info(() => $"__result is: {__result.GetType().CompactDescription()}");`
`24`		`-`
`25`	`23`	`__result.RunInUpdates(0, () =>`
`26`	`24`	`{`
`27`	`25`	`if (__result is ValueInput<floatQ> floatQInput)`