fix NameValueList equals, in case this is an empty NameValueList #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hey @macvoo ! Thanks for taking the time to submit this PR ❤️ !! Could you please take a look at our Open Source Playbook and then proceed with signing our CLA, so we can then move forward with processing this? Thanks in advance! |
Contributor
|
thanks for signing the CLA @macvoo ! Passing this on for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling NameListValue#equals on a empty NameValueList (handing over another NameValueList) would always return true in the current implementation.
CodeSample:
//Given:
NameValueList a = new NameValueList();
NameValueList b = new NameValueList();
b.set("someName", "someValue");
//When
a.equals(b); --> would be true, but should be false...