fix GXS infinite reload of unprocessed items at startup #260
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
GXS Channels service was experiencing a massive CPU and memory spike at every startup. Thousands of "Unprocessed" items were being reloaded in an infinite loop because they were never successfully acknowledged and persisted as "Processed" in the database.
Root Causes
UNPROCESSEDstate forever.RsGxsDataAccess::getMsgIdList, if a filter resulted in zero matches, it returned an empty ID set. The lower-level DB layer interpreted an empty set as "fetch everything," effectively bypassing the filter and reloading already-processed items.Proposed Changes
protectedvisibility to allow services to force DB synchronization.Impact