Do not transfer service strings #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During GXS syncing, the group's service string was transferred. This would possibly overwrite locally computed data.
Contributor
Author
|
AFAIK, GXS Identity uses service strings to store PGP validation and reputation scores. GXS Channels uses it to store if a channel has auto file download activated. Those locally computed data might get overwritten by a peer during syncing. |
Contributor
|
Good catch! A side effect of your PR is that the service string is not locally saved either. Isn't it a problem? |
Contributor
Author
|
Well, I would need your confirmation there but I believe the serialise() and deserialise() part of rsgxsdata.cc only applies to GXS transfers. The actual saving of the group is done by the RS_SERIAL_PROCESS() macros in rsgxsifacetypes.h (and it does handle mServiceString). |
Contributor
|
Actually the saving is done in storeGroup(). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During GXS syncing, the group's service string was transferred. This would possibly overwrite locally computed data.