JS Calculator Lab Pt1 Final#1
Open
seagreenmedia wants to merge 3 commits intoReturn-Ready-2021-JavaScript-Evening:mainfrom
Open
JS Calculator Lab Pt1 Final#1seagreenmedia wants to merge 3 commits intoReturn-Ready-2021-JavaScript-Evening:mainfrom
seagreenmedia wants to merge 3 commits intoReturn-Ready-2021-JavaScript-Evening:mainfrom
Conversation
kburd
reviewed
Nov 12, 2020
| <div> | ||
| <td colspan="2"> | ||
| <button class="radDeg"><a>Rad</a> | <a>Deg</a></button> | ||
| <!-- <span class="radDeg"> |
There was a problem hiding this comment.
Remove commented out code before committed
| <h1><a href="indexStandard.html">Standard</a> | ||
| <a>| Scientific</a></h1> | ||
| <div class="content"> | ||
| <table> |
There was a problem hiding this comment.
You should never use a table to build a layout (-5)
| <h1><a>Standard |</a> | ||
| <a href="indexScientific.html">Scientific</a></h1> | ||
| <div class="content"> | ||
| <table> |
| </div> | ||
| </body> | ||
|
|
||
| </html> No newline at end of file |
There was a problem hiding this comment.
Great work, love the color scheme! Only issue was the table layout. 90%
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.