Calculator-Js#4
Open
ChampionModeVision wants to merge 2 commits intoReturn-Ready-2021-JavaScript-Evening:mainfrom
Open
Calculator-Js#4ChampionModeVision wants to merge 2 commits intoReturn-Ready-2021-JavaScript-Evening:mainfrom
ChampionModeVision wants to merge 2 commits intoReturn-Ready-2021-JavaScript-Evening:mainfrom
Conversation
kburd
reviewed
Nov 12, 2020
|
|
||
|
|
||
|
|
||
| .btm{ |
Calculator.css
Outdated
|
|
||
|
|
||
|
|
||
| .trow{ |
There was a problem hiding this comment.
All of these row class selectors have the same styling. You should create one and reuse it (-1)
Calculator.css
Outdated
|
|
||
| } | ||
|
|
||
| #purp{ |
There was a problem hiding this comment.
(-2) Equals sign does not highlight on hover. Remove this id selector and replace it with a class selector and your problem will be fixed
| <div class="card-body"> | ||
|
|
||
| <div class="container"> | ||
| <form> |
There was a problem hiding this comment.
I did not specify this but the display at the top should be read only. Drop the form as we don't want it for the next step
Calculator.html
Outdated
| </div> | ||
|
|
||
|
|
||
| <span class="trow"> |
|
|
||
|
|
||
|
|
||
| </html> No newline at end of file |
There was a problem hiding this comment.
Minor style issues. Make sure you format/indent your documents correctly. (-2)
95/100 Great work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.