Calculator JS evening#6
Open
gee92 wants to merge 1 commit intoReturn-Ready-2021-JavaScript-Evening:mainfrom
Open
Calculator JS evening#6gee92 wants to merge 1 commit intoReturn-Ready-2021-JavaScript-Evening:mainfrom
gee92 wants to merge 1 commit intoReturn-Ready-2021-JavaScript-Evening:mainfrom
Conversation
kburd
reviewed
Nov 17, 2020
| background-color: grey; | ||
| } | ||
|
|
||
| .frow{ |
There was a problem hiding this comment.
All of these row selectors have the same styling. Create one selector and use it throughout your HTML (-1)
| font-size: 1em; | ||
| color: white ; | ||
| } | ||
| a:hover{ |
There was a problem hiding this comment.
Wasn't required but nice additional touch!
|
|
||
| <h1> Scientific | <a href="standard.html"> Standard</a> </h1> | ||
|
|
||
| <input type="text" class="Scientific" name="display"> |
| </div> | ||
|
|
||
| <div> | ||
| <button class="4row"> e</button> |
| </html> | ||
| </body> | ||
|
|
||
| </Html> No newline at end of file |
There was a problem hiding this comment.
Minor styling issues, make sure indentation is consistent (-1)
95% Nice work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.