Open
Conversation
kburd
reviewed
Dec 28, 2020
kburd
left a comment
kburd
left a comment
There was a problem hiding this comment.
Part one (-7)
Missing part 2 (-33)
Missing Part 3 (-33)
Finish up part 2 and 3 and resubmit (27%)
domlab.js
Outdated
| // f to c cnvertor function | ||
|
|
||
| function calc(userInput){ | ||
| userInput = document.getElementsByClassName('userInput').value |
There was a problem hiding this comment.
Incorrectly getting user input, console.log() the userInput and tweak your code until you get the number the user entered to display in the console (-2)
domlab.js
Outdated
| userInput = document.getElementsByClassName('userInput').value | ||
| let c = document.getElementsByClassName('c').value | ||
| c += userInput - 32 * (5/9) | ||
| console.log(c) |
There was a problem hiding this comment.
You should update the celsius value on the screen with the calculated value, not console.log() the value (-5)
domlab.js
Outdated
|
|
||
| let button = document.getElementsByClassName('calculateButton') | ||
|
|
||
| button[0].addEventListener('click', calc); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
just realized I never created a pull req for the original submission