Skip to content

correct lab #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DBenson05 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

correct lab #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 60 additions & 0 deletions forms.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
<!DOCTYPE html>
<html>
<head>
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/bootstrap@4.5.3/dist/css/bootstrap.min.css" integrity="sha384-TX8t27EcRE3e/ihU7zmQxVncDAy5uIKz4rEkgIXeMed4M0jlfIDPvg6uqKI2xXr2" crossorigin="anonymous">
</head>
<body>
<header class="bg dark">
<h1 class="text-center">Form</h1><br>

</header>
<style>
Copy link
Copy Markdown

@kburd kburd Nov 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove empty style tags


</style>
<span class="border border-dark" .m1></span>
Copy link
Copy Markdown

@kburd kburd Nov 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty span can be deleted

<form>
<label for="name">First Name</label>
<input type="text" id="name" name="name"><div>
Copy link
Copy Markdown

@kburd kburd Nov 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for the div here or below (-1)


<label for="name">Last Name</label>
<input type="text" id="name" name="name"></div> <br>

<label for="contact">Contact Phone Number</label>
<input type="text" id="Contact Phone Number" name="name">

<label><small>Phone Number Type</label>
<input type="radio" name="Phonenumbertype" value="Land Line"> <label>Landline</label>
<input type="radio" name="Phonenumbertype" value="Cell"> <label>Cell</label></small><div>

<label>Contact Email</label>
<input type="text" id="Contact Emailr" name="contactemail"></div><br>

<label for="howdidyouhearaboutus"><div>How Did You Hear About Us</label></div>
<select name="howdidyouhearaboutus" id="howdidyouhearaboutus">
<option value="search Engine">Search Engine</option>
<option value="socail Media">Social Media</option>
<option value="Recruiter">Recruiter</option>
</select>
<label>interest For Contacting</label><br>
<input type="text" id="Interest for contacting" name="interestforcontacting"><br>
Copy link
Copy Markdown

@kburd kburd Nov 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra input



<label>Skill Set</label><br>
Copy link
Copy Markdown

@kburd kburd Nov 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra label, the "Interest for contacting" label should be for this input (-1)

<input type="checkbox" name="skillset1" value="manager"><label>Manager</label><br>
<input type="checkbox" name="skillset2" value="marketing"><label>Marketing</label><br>
<input type="checkbox" name="skillset3" value="webdesign"><label>Web Design </label><br>
</span>
Copy link
Copy Markdown

@kburd kburd Nov 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the opening tag?


</label>




</form>




</body>

</html>
Copy link
Copy Markdown

@kburd kburd Nov 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing character limit on all fields (-3)
Missing Text Area (-5)

59 changes: 59 additions & 0 deletions portfolio.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
<!DOCTYPE html>
<html>
<header><tittle>Resume</tittle></header>
Copy link
Copy Markdown

@kburd kburd Nov 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be head here (-1)


<img src="C:\Users\user\Pictures\resumephoto.jpg" style="width: 20%; height: 20%;" alt="Resume Photo"><br>
Copy link
Copy Markdown

@kburd kburd Nov 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing image file (-2)
Path is absolute (-1)

<a href="https://www.linkedin.com/in/daron-benson-7b0a769a/">Linkedin.com</a>



<body>
<head>
Copy link
Copy Markdown

@kburd kburd Nov 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be header (-1)

<h2>DaRon Benson</h2>
Copy link
Copy Markdown

@kburd kburd Nov 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(-1) Your headers are assigned incorrectly. The headers should trend upwards as the info becomes less relevant. For example:
<h1>DaRon Benson
<h2>Experience
<h3>Mixer


<h5>objectives</h5>
<p>Dedicated software developer who is a detail-oriented, and self motivated, With a background
in inside sales and customer service. <br>Who effectively multi-tasks and balances customer needs with
company demands.</p>


<h5>Experience</h5>
<p><h3>Mixer</h3> <em>Consolidated construction services</em>

<br>- Blades, DE
August 2018 to Present

<br>Correct low spots and holes in concrete floors with epoxy. Create the mixes for the installers, so they
can install the epoxy.
</p>
<p>
<h3>Manager/Owner</h3>
<em>illustrated Thoughts Entertainment</em>

<br>- Millsboro, DE

<br>August 2016 to Present

As manager of Illustrated Thoughts Entertainment
<br><ul>
<li>.Advise independent Musicians on the entertainment business.</li>
Copy link
Copy Markdown

@kburd kburd Nov 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for the . at the beginning of each line

<li>.Assist and coordinat concerts.</li>
<li>.Schedul interviews, studio time, music videos etc. </li>
<li>.increased musicians streams from less then 100 streams to 881,000, streams in a year.</li>
<li>.Market and Brand independent musicians through websites and fan interaction.</li>
<li>.Respond and resolve any financial disputes</li>
</ul>
</p>
<h3>Education</h3>
<p><h5></h5>High School Graduate</p>
</header>
<footer>
Copy link
Copy Markdown

@kburd kburd Nov 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for the empty footer tag

</footer>

</body>


Copy link
Copy Markdown

@kburd kburd Nov 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing closing html tag (-1)





Copy link
Copy Markdown

@kburd kburd Nov 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor Styling mistakes (-1)

82/100
Focus on attention to detail. The were a number of silly mistakes around extra tags. Make sure you only use what you need. Great job besides that!