Skip to content

Lab #1 #4

Open
MackeyH wants to merge 5 commits intoReturn-Ready-2021-JavaScript-Evening:mainfrom
MackeyH:main
Open

Lab #1 #4
MackeyH wants to merge 5 commits intoReturn-Ready-2021-JavaScript-Evening:mainfrom
MackeyH:main

Conversation

@MackeyH
Copy link
Copy Markdown

@MackeyH MackeyH commented Oct 28, 2020

FB profile pic

@kburd kburd self-requested a review October 29, 2020 14:38
@@ -0,0 +1,57 @@
<!DOCTYPE html>
<html>
<title>Contact Form</title>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure this is in the <head> tag

<div>
<section>
<figure>
<img src="Demos/img/Carl Madison.jpg" alt="Profile Pic" style="width:200px;height:200px;">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File path and file name are wrong, it should be src="FB profile pic.jpg" based off of what you submitted (-2)

</footer>
</div>
</body>
</html> No newline at end of file
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor formatting issues (-1)

97/100 Great work! Keep it up


<!-- Phone number button -->
<label>Phone Number:</label>
<input required type="text" id="phone_number" name="user_phone_number" pattern="[0-9]{10}" title="10 digit Phone Number" maxlength="10"><br><br>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice validation!

<button type="submit">Submit</button>
</form>
</body>
</html> No newline at end of file
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small formatting issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants