Merged
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis pull request bumps the SDK version from 2.1.3.x to 2.1.4.0 by updating version strings across configuration files, module docstrings, and subproject references. One file updates numeric validation regex patterns with optional minus sign support. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
|
🤖 SDK Version Check ✅ Version automatically updated to
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
sdk/open_api/__init__.py (1)
10-17:⚠️ Potential issue | 🟠 MajorUpdate the exported package version as well.
This PR bumps the generated SDK/spec version, but
sdk.open_api.__version__on Line 17 still reports2.0.0. That leaves the runtime package metadata out of sync with the release and can break consumers that introspect the SDK version.Proposed fix
-__version__ = "2.0.0" +__version__ = "2.1.4.0"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@sdk/open_api/__init__.py` around lines 10 - 17, The package-level __version__ variable is still "2.0.0" and must be updated to match the generated OpenAPI doc version; update sdk.open_api.__version__ (the __version__ string in sdk/open_api/__init__.py) to "2.1.4" so runtime package metadata matches the SDK/spec bump.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@sdk/open_api/configuration.py`:
- Around line 499-500: Update the hardcoded SDK package version string that
currently reads "SDK Package Version: 2.0.0" (the string literal in
configuration.py) and the package version constant (likely __version__ in
open_api.__init__) so both match the project version 2.1.4.0; either replace the
literal "2.0.0" with "2.1.4.0" in the configuration string and set __version__ =
"2.1.4.0" in __init__.py, or refactor both locations to read the version
dynamically from pyproject.toml (e.g., via importlib.metadata or parsing) so
they stay in sync.
---
Outside diff comments:
In `@sdk/open_api/__init__.py`:
- Around line 10-17: The package-level __version__ variable is still "2.0.0" and
must be updated to match the generated OpenAPI doc version; update
sdk.open_api.__version__ (the __version__ string in sdk/open_api/__init__.py) to
"2.1.4" so runtime package metadata matches the SDK/spec bump.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 68918080-f0f2-4894-89b8-5bef03d8ee0c
📒 Files selected for processing (52)
pyproject.tomlsdk/open_api/__init__.pysdk/open_api/api/market_data_api.pysdk/open_api/api/order_entry_api.pysdk/open_api/api/reference_data_api.pysdk/open_api/api/specs_api.pysdk/open_api/api/wallet_data_api.pysdk/open_api/api_client.pysdk/open_api/configuration.pysdk/open_api/exceptions.pysdk/open_api/models/__init__.pysdk/open_api/models/account.pysdk/open_api/models/account_balance.pysdk/open_api/models/account_type.pysdk/open_api/models/asset_definition.pysdk/open_api/models/cancel_order_request.pysdk/open_api/models/cancel_order_response.pysdk/open_api/models/candle_history_data.pysdk/open_api/models/create_order_request.pysdk/open_api/models/create_order_response.pysdk/open_api/models/depth.pysdk/open_api/models/depth_type.pysdk/open_api/models/execution_type.pysdk/open_api/models/fee_tier_parameters.pysdk/open_api/models/global_fee_parameters.pysdk/open_api/models/level.pysdk/open_api/models/liquidity_parameters.pysdk/open_api/models/market_definition.pysdk/open_api/models/market_summary.pysdk/open_api/models/mass_cancel_request.pysdk/open_api/models/mass_cancel_response.pysdk/open_api/models/order.pysdk/open_api/models/order_status.pysdk/open_api/models/order_type.pysdk/open_api/models/pagination_meta.pysdk/open_api/models/perp_execution.pysdk/open_api/models/perp_execution_list.pysdk/open_api/models/position.pysdk/open_api/models/price.pysdk/open_api/models/request_error.pysdk/open_api/models/request_error_code.pysdk/open_api/models/server_error.pysdk/open_api/models/server_error_code.pysdk/open_api/models/side.pysdk/open_api/models/spot_execution.pysdk/open_api/models/spot_execution_list.pysdk/open_api/models/spot_market_definition.pysdk/open_api/models/tier_type.pysdk/open_api/models/time_in_force.pysdk/open_api/models/wallet_configuration.pysdk/open_api/rest.pyspecs
tomdevman
approved these changes
Mar 11, 2026
The generate-api.sh script was hardcoding packageVersion=2.0.0, causing the autogenerated open_api files to report a stale SDK version. Now reads the version dynamically from pyproject.toml. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
🤖 SDK Version Check ✅ Version automatically updated to
|
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
🤖 SDK Version Check ✅ Version automatically updated to
|
- version-consistency: skip commit when version is already up to date instead of failing on "nothing to commit" - pylint: use single `poetry install --extras dev` instead of separate install + extras steps, which caused dev deps to be missing Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
🤖 SDK Version Check ✅ Version automatically updated to
|
Poetry's --extras flag doesn't reliably resolve [project.optional-dependencies]. Use pip install -e ".[dev]" inside the poetry venv instead, which natively understands PEP 621 optional dependencies. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
🤖 SDK Version Check ✅ Version automatically updated to
|
- Fix isort import ordering in market_trackers.py - Fix black formatting in test_dynamic_pricing.py - Fix flake8 F541: remove f-prefix from strings without placeholders - Fix mypy: add None guards before float() on Optional fields Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
🤖 SDK Version Check ✅ Version automatically updated to
|
tomdevman
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Bug Fixes
Chores