Open
Conversation
* ARC-TF now runs on Linux. * There are still some problems with directories, such as \ instead of /. One solution can be to use os.pathjoin() .
* Added script header, imports, and display handling section;
* review of Current_Tab() function - docstring, comments in english and variable names;
* review of ClearWidget() function - docsctring, comments in english and variable names;
* creation of clear_frame.py module in Include, as auxiliary function for the ClearWidget();
* included docstring, comments in english, and deleted code that was unnecessary;
* included docstring, comments in english, and rewrote the code to be more readable, and avoid unnecessary loops;
* added docstring and comments in english;
* removed unnecessary code;
* added docstrings and comments in english;
* changed some variable names to be more descriptive, and rearranjed some code for clarity;
* still needs some refactoring;
* merged Final_Calculation() and ROI_Thick_Calculation() into a single funtion called Thickness_Calculation() - created docstring and comments in english;
* merged ResultManager() and ROIResultManager() into a single function called ResultManager() - created docstring and comments in english;
* changed Final_Results() and ROI_Select_Alg functions accordingly;
* tested the workflow for the new changes and it works as before; but still needs to be revisited for variable names and code structure;
* included docstring and comments in english;
* removed unnecessary code;
* still need to test that this feature is working properly;
* needs additional code review for variable names and logic;
* merged both Linearize() and LinearizeWithErrors() functions into a single function called LinearRegression();
* included docstring and comments in english;
* tested the code and it works as expected;
* still needs to be cheked for unnecessary code, variable names and other improvements;
* changed Final_Results() accordingly;
* ManSelec_Alg(), Threshold_Alg(), ROI_Select_Alg(), showimage(), onclick(), DataUploader(), and handleTabChange() functions;
* added docstring, and comments in english;
* tested and it works;
* further review may be necessary to check for code logic;
* added remove_file.py script to the Include directory, forgoten in a previous commit - related to the ClearWidget fucntion;
* reviewed SourceReader(), Method(), on_entry_change(), Delete(), File_Manager(), and Save_Results() functions - created docstrings, added comments in english, renamed variables to be more descriptive, and deleted unnecessary code;
* tested the code, and it is working;
* reviewed classes Skeleton, Warnings, Tabs and Plot; checked for code clarity, meaningful variable names, created docstrings and headers, and wrote comments in english;
* need to check again the Tabs class, regarding the definition of decay, regression and "variable" variables (this is not so good at the moment);
* changed the global variable "Notebook" to "tab_manager"; this has notebook-like properties from the TKinter tkk package, but this way it gets less confuse;
* changed the global variable "wng" to "warnings_manager" - self-explanatory;
* hard-fixing conflicts from previous merge with the "review" branch;
* tested - it works as before;
…ce. 2.Addressed and solved Temp file issues cross operating systems.
…till not fully done(labels))
… Made two file options(Source or Source+Film) for XRA tab 3. Plotted two files combined for XRA tab.
… need to work on it)
…and 'Source + Film' labels before centroid values
…, added buttons for film, source selection and run.
…ix file reading issue affecting centroid visualization
…ess Calculation 3. Uncertainty Calculation 4. Count rate instead of counts
…ounts for calib and material trials
…ration, Material Tabs)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The internship25 branch will be used in the LIP Summer Internship programme 2025.
In the review branch, modifications to the master branch were done to include descriptive headers and docstrings for (almost) every function, as well as comments in english, to facilitate reading the code.
Some variable names were also modified to be more meaningful.
The review branch was merged with the internship25 branch, where T. Campante adapted some pieces of the code so the interface runs in Linux. After some initial tests, we see that everything seems to work fine in Windows, but not on Linux.
Aditional tests are required.