add plotGaps option to SvgLine and prevent plotting nulls by default#8
Open
briancray wants to merge 9 commits intoRich-Harris:masterfrom
Open
add plotGaps option to SvgLine and prevent plotting nulls by default#8briancray wants to merge 9 commits intoRich-Harris:masterfrom
briancray wants to merge 9 commits intoRich-Harris:masterfrom
Conversation
Author
|
ping, any thoughts on this one? |
Author
|
Is there anything blocking this PR? If so I can just fork it and publish a fork for now... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our use case nulls are very significant. Right now they are plotted as 0s and to me it makes more sense that the default is to show gaps in the SvgLine. I've added
plotGapsoption that whentruewill plot them as 0.