Skip to content

feat: DingTalk Stream模式完整实现#769

Closed
young13shao wants to merge 1 commit intoRightNow-AI:mainfrom
young13shao:dingtalk-stream
Closed

feat: DingTalk Stream模式完整实现#769
young13shao wants to merge 1 commit intoRightNow-AI:mainfrom
young13shao:dingtalk-stream

Conversation

@young13shao
Copy link
Copy Markdown

  • 修复ticket字段提取(非token)
  • WebSocket连接添加ticket参数
  • 实现消息类型处理(SYSTEM/CALLBACK/EVENT)
  • 添加ACK响应
  • 实现sessionWebhook回复功能
  • 添加reply_url字段到ChannelUser结构体
  • 修复web_fetch UTF-8截断panic
  • 所有Channel适配器添加reply_url支持

Summary

Changes

Testing

  • cargo clippy --workspace --all-targets -- -D warnings passes
  • cargo test --workspace passes
  • Live integration tested (if applicable)

Security

  • No new unsafe code
  • No secrets or API keys in diff
  • User input validated at boundaries

- 修复ticket字段提取(非token)
- WebSocket连接添加ticket参数
- 实现消息类型处理(SYSTEM/CALLBACK/EVENT)
- 添加ACK响应
- 实现sessionWebhook回复功能
- 添加reply_url字段到ChannelUser结构体
- 修复web_fetch UTF-8截断panic
- 所有Channel适配器添加reply_url支持
@jaberjaber23
Copy link
Copy Markdown
Member

Reviewed. The implementation is solid but this needs to be split into 2 PRs: (1) the reply_url structural change across all adapters, (2) DingTalk Stream mode. Also please remove the warn! log that dumps first 200 chars of every received message as it leaks message content at WARN level.

@jaberjaber23
Copy link
Copy Markdown
Member

Closing. This PR has ~58K lines of changes across 42 files, with the actual DingTalk work buried under mass reformatting of 40+ unrelated channel adapters. This is unreviewable. PRs #810 and #840 provide the same DingTalk stream functionality in clean, focused, testable diffs. Please extract only DingTalk-specific changes if anything is missing from #810/#840.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants