runtime: add config switches for memory and embeddings#842
Open
CastleOneX wants to merge 1 commit intoRightNow-AI:mainfrom
Open
runtime: add config switches for memory and embeddings#842CastleOneX wants to merge 1 commit intoRightNow-AI:mainfrom
CastleOneX wants to merge 1 commit intoRightNow-AI:mainfrom
Conversation
(cherry picked from commit 209e0075365b3a6133571aee1c2dddbc558dcf55)
Member
|
Reviewed. The feature logic is correct but CI is failing (format check and ubuntu test). Please run cargo fmt and add unit tests for MemoryConfig defaults and deserialization with missing fields. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
OpenFang did not have an explicit runtime-level way to disable memory entirely or disable embedding-backed recall independently. In practice, memory behavior could still partially activate unless provider setup failed in a particular way, which led to unnecessary embedding initialization attempts, noisy fallback paths, and avoidable external calls.
What this changes
Why this is useful upstream
Validation