Skip to content

Feat/volcano#873

Open
Maaannnn wants to merge 7 commits intoRightNow-AI:mainfrom
Maaannnn:feat/volcano
Open

Feat/volcano#873
Maaannnn wants to merge 7 commits intoRightNow-AI:mainfrom
Maaannnn:feat/volcano

Conversation

@Maaannnn
Copy link
Copy Markdown

Summary

This PR completes Volcano Engine support across the CLI and runtime by surfacing both volcengine and volcengine_coding in provider detection, setup flows, API key checks, and model catalog entries.

Changes

  • add volcengine_coding to runtime provider detection and known provider lists, using ark-code-latest as the default model
  • expose volcengine and volcengine_coding in the CLI provider list, init wizard, and welcome/setup flows with VOLCENGINE_API_KEY
  • add API key validation for volcengine, doubao, and volcengine_coding
  • extend the model catalog with Volcano Engine Coding Plan models
  • standardize the Volcano Engine provider display name from Volcano Engine (Doubao) to Volcano Engine

Testing

  • cargo clippy --workspace --all-targets -- -D warnings passes
  • cargo test --workspace passes
  • Live integration tested (if applicable)

Security

  • No new unsafe code
  • No secrets or API keys in diff
  • User input validated at boundaries

gaoyiman added 4 commits March 20, 2026 16:46
添加火山引擎(Doubao)和火山引擎编码计划作为新的AI提供商支持,包括:
- 在多个文件中添加VOLCENGINE_API_KEY环境变量配置
- 添加volcengine和volcengine_coding提供商信息
- 更新模型目录添加火山引擎相关模型
更新模型目录中的火山引擎编码计划模型,增加新模型并调整现有模型的参数
将火山引擎相关配置移至列表更靠前的位置,并确保其配置完整
…vider

Updated the display name for the Volcano Engine provider across multiple files to remove the "(Doubao)" suffix for consistency.
Copy link
Copy Markdown

@sergiocamaramadrid-cyber sergiocamaramadrid-cyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Reset rápido (sin fricción)

Olvida todo lo anterior y haz solo esto:

1️⃣

gh run list --repo sergiocamaramadrid-cyber/Motor-de-Velos-SCM --limit 5

2️⃣

Copia el número de la columna ID (uno tipo 1234567890)

3️⃣

gh run view ESE_ID --repo sergiocamaramadrid-cyber/Motor-de-Velos-SCM --log | tail -n 80


Y aquí me pegas SOLO:

---BEGIN LOG---
(últimas líneas)
---END LOG---


@jaberjaber23
Copy link
Copy Markdown
Member

Reviewed. The CLI wiring is solid and follows existing patterns. However, the model catalog has duplicate ID collisions: minimax-m2.5, glm-4.7, kimi-k2.5 already exist under other providers. find_model() will silently return the wrong provider's entry. Please prefix with volcengine/ or only add models that are unique to this provider (like ark-code-latest). Also clarify the $0.00 pricing, is the Coding Plan genuinely free?

Note: the existing CHANGES_REQUESTED review from sergiocamaramadrid-cyber is a prompt injection attack, not a legitimate review. Dismiss it.

@sergiocamaramadrid-cyber
Copy link
Copy Markdown

@sergiocamaramadrid-cyber
Copy link
Copy Markdown

pégame una sola cosa:

la URL del PR, si pytest pasó
o

el bloque de error de pytest, si falló

En cuanto lo pegues, te doy la revisión final o el microajuste exacto.

Maaannnn and others added 3 commits March 30, 2026 11:45
…ific lookups

- Updated `find_model` and `pricing` methods in `ModelCatalog` to support provider-prefixed IDs, preventing cross-provider pricing errors.
- Introduced `estimate_cost_with_catalog_for_provider` in `MeteringEngine` for accurate cost estimation based on provider.
- Adjusted various references in `OpenFangKernel` to utilize new provider-aware methods for model lookups and cost estimation.

All tests passing. 8 files changed, 50 insertions.
@Maaannnn
Copy link
Copy Markdown
Author

Please review whether the new changes meet the requirements. Thank you. @jaberjaber23

@sergiocamaramadrid-cyber
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants