fix: select crypto provider (#903)#906
Open
hello-world-bfree wants to merge 2 commits intoRightNow-AI:mainfrom
Open
fix: select crypto provider (#903)#906hello-world-bfree wants to merge 2 commits intoRightNow-AI:mainfrom
hello-world-bfree wants to merge 2 commits intoRightNow-AI:mainfrom
Conversation
Member
|
Reviewed. Two issues: (1) The Discord heartbeat fix is unrelated to the crypto provider fix. Split into two PRs. (2) The install_default() Result is silently discarded with let _ =. At minimum add a debug log. |
4d3cb78 to
3ebd282
Compare
3ebd282 to
57746de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Install the rustls CryptoProvider (
ring) at kernel boot to fix a panic when channel adapters (e.g. Discord) open TLS connections. Rustls 0.23+ can't auto-select a provider when bothringandaws-lc-rsare in the dependency tree. Resolves #903Note
There's also an issue with the Discord Gateway protocol. At the moment the client does not send a heartbeat. This adds that in.
Changes
rustls(withringfeature) as a workspace dependency - Addedrustlstoopenfang-kernelcrate - Callinstall_default()as the first line ofboot_with_config(), before anyreqwest::ClientconstructionTesting
cargo clippy --workspace --all-targets -- -D warningspassescargo test --workspacepassesSecurity