feat(arm64): fix rmcp-sdk compatibility and add arm64 documentation#947
Open
w8explorer wants to merge 2 commits intoRightNow-AI:mainfrom
Open
feat(arm64): fix rmcp-sdk compatibility and add arm64 documentation#947w8explorer wants to merge 2 commits intoRightNow-AI:mainfrom
w8explorer wants to merge 2 commits intoRightNow-AI:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables building and running OpenFang on ARM64 (aarch64) architectures. It addresses a critical compilation error in the rmcp SDK and provides a dedicated deployment guide for ARM-based cloud environments.
Changes
Core Fix: Refactored crates/openfang-runtime/src/mcp.rs to use Default::default() for StreamableHttpClientTransportConfig. This resolves error E0639 caused by the #[non_exhaustive] attribute in the latest rmcp library.
Documentation: Added docs/arm64.md detailing native system dependencies and build instructions for aarch64 Linux.
Visibility: Added an "ARM64 Support" link to the main README.md header.
Testing
cargo clippy --workspace --all-targets -- -D warnings (Verified on ARM64).
cargo check -p openfang-runtime passes on Neoverse-N1 architecture.
Live integration tested on Oracle Cloud ARM64 instance.
Security
No new unsafe code.
No secrets or API keys in diff.
User input validated at boundaries.
Technical Assistance: Code debugging, architecture verification, and documentation were assisted by Antigravity (an AI by Google DeepMind).