Crash woes

[ohlidalp]

RoRserver crashes a lot. In effort to make gdb backtraces more informative, I partitioned the code to smaller functions. I also checked printf() format strings.

see https://forum.rigsofrods.org/threads/rorserver-woes.3225/

@tritonas00 If you get really bored, I found a tutorial (actually 2 explaining the same mechanism) how to pinpoint the exact crash site with gdb breakpoints:

• https://esp32.com/viewtopic.php?t=6623
• https://wiki.gentoo.org/wiki/Stack-smashing-debugging-guide

[tritonas00]

Got many AS warnings (i build with cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo -DRORSERVER_WITH_ANGELSCRIPT:BOOL=ON .)

/home/babis/Downloads/ror-server/dependencies/angelscript/include/angelscript.h:620:11: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  620 |           if( hasCopyConstructor )

one warning

/home/babis/Downloads/ror-server/source/server/userauth.cpp: In member function ‘int UserAuth::readConfig(const char*)’:
/home/babis/Downloads/ror-server/source/server/userauth.cpp:98:20: warning: ‘char* strncpy(char*, const char*, size_t)’ output may be truncated copying 40 bytes from a string of length 2047 [-Wstringop-truncation]
   98 |             strncpy(user_nick, c, NICK_LEN);

and one error

/home/babis/Downloads/ror-server/source/server/sequencer.cpp: In member function ‘broadcastType Sequencer::ProcessUtf8Chat(Client*, int, unsigned int, char*, unsigned int)’:
/home/babis/Downloads/ror-server/source/server/sequencer.cpp:1148:56: error: invalid conversion from ‘int’ to ‘broadcastType’ [-fpermissive]
 1148 |         if (scriptpub != BROADCAST_AUTO) publishMode = scriptpub;
      |                                                        ^~~~~~~~~
      |                                                        |
      |                                                        int

[ohlidalp]

Obsoleted by #143