🔧 Replaced jsoncpp with Poco::JSON#141
Open
AnotherFoxGuy wants to merge 1 commit intoRigsOfRods:masterfrom
Open
🔧 Replaced jsoncpp with Poco::JSON#141AnotherFoxGuy wants to merge 1 commit intoRigsOfRods:masterfrom
AnotherFoxGuy wants to merge 1 commit intoRigsOfRods:masterfrom
Conversation
5 tasks
ohlidalp
requested changes
Aug 17, 2022
Member
ohlidalp
left a comment
ohlidalp
left a comment
There was a problem hiding this comment.
- Undo the
SendMessage() -> SWSendMessage()find&replace please. I see no reason for that. - Make the
JsonToString()macro a function - I see no reason to make it a macro.
Member
Author
The issue with that is that the |
AnotherFoxGuy
force-pushed
the
jsoncpp-gone
branch
2 times, most recently
from
428b367 to
2a92010
Compare
AnotherFoxGuy
force-pushed
the
jsoncpp-gone
branch
from
2a92010 to
a832597
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #139