🎉 Replace old Http and MasterServer code with a new API interface#165
Draft
Zentro wants to merge 9 commits intoRigsOfRods:masterfrom
Draft
🎉 Replace old Http and MasterServer code with a new API interface#165Zentro wants to merge 9 commits intoRigsOfRods:masterfrom
Http and MasterServer code with a new API interface#165Zentro wants to merge 9 commits intoRigsOfRods:masterfrom
Conversation
the HTTP response code may end up being 0 when endpoint isn't configured.
Default value is 'http://127.0.0.1:8080' because that's what Zentro used during development. The production value is 'https://v2.api.rigsofrods.org' but that may obviously change.
* always-empty variable `Client::m_api_key_key` causing config not to work. * undefined function `Config::GetApiKeyKey()` causing linking error. * unitialized variable `Client::m_api_active`, causing rorserver to attempt deauth on shutdown even in LAN mode. * misnamed variable in sequencer.cpp, causing compile error.
Member
|
I've dusted this off, adding commits I had in my repo and making sure it builds and runs. I haven't tested the auth tho. Changes:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of the efforts to modernize multiplayer and online experiences, these changes will allow for the server to interact with the "new" API.
As part of these changes:
What does this mean? You no longer have to copy and paste a long token into your client. Instead, you can create one directly from your client and use it to identify yourself as a server "admin" or "mod." If you're logged in with your forum account, your client will automatically send a temporary challenge request to the API. The server can then use this request to verify your identity against the API and assign you the "ranked" role.