Skip to content

Review corrections#130

Merged
hegedus-mark merged 7 commits intodevelopmentfrom
review-corrections
Dec 8, 2024
Merged

Review corrections#130
hegedus-mark merged 7 commits intodevelopmentfrom
review-corrections

Conversation

@pixhy
Copy link
Collaborator

@pixhy pixhy commented Dec 8, 2024

No description provided.

@pixhy pixhy requested a review from hegedus-mark December 8, 2024 21:29
README.md Outdated
```
2. **Docker setup**:
- Add docker to your services
- Run the docker-compose.yml file to create the database in Docker.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small suggestion here, you could write down the docker command:
docker compose up

And the docker compose file runs the entire server, frontend and database so it's not just the database
and you should tell them to navigate to http://localhost:3000 (we didn't implement https in docker)

Copy link
Collaborator

@hegedus-mark hegedus-mark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@hegedus-mark hegedus-mark merged commit fbb3c97 into development Dec 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants