Skip to content

Fix add selection behavior when both arguments are dates #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
salmonumbrella wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

Fix add selection behavior when both arguments are dates #318

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/utils/predefinedSelections.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import differenceInWeeks from "date-fns/differenceInWeeks";
import differenceInMonths from "date-fns/differenceInMonths";
import differenceInYears from "date-fns/differenceInYears";
import datefnsFormat from "date-fns/format";
import startOfDay from "date-fns/startOfDay";
import type { QBClause, Result as QueryResult } from "./types";
import getTextByBlockUid from "roamjs-components/queries/getTextByBlockUid";
import updateBlock from "roamjs-components/writes/updateBlock";
Expand Down Expand Up @@ -435,7 +436,8 @@ const predefinedSelections: PredefinedSelection[] = [
const val0 = getArgValue(arg0, result);
const val1 = getArgValue(arg1, result);
if (val0 instanceof Date && val1 instanceof Date) {
return val1;
const dayOffset = differenceInDays(startOfDay(val1), startOfDay(new Date()));
return new Date(val0.valueOf() + dayOffset * MILLISECONDS_IN_DAY);
} else if (val0 instanceof Date) {
return new Date(
val0.valueOf() + MILLISECONDS_IN_DAY * (Number(val1) || 0)
Expand Down