Modularize sticky notes and fix code review findings#3
Open
salmonumbrella wants to merge 2 commits intoRoamJS:mainfrom
Open
Modularize sticky notes and fix code review findings#3salmonumbrella wants to merge 2 commits intoRoamJS:mainfrom
salmonumbrella wants to merge 2 commits intoRoamJS:mainfrom
Conversation
- Document intentional removal of startup database write in toStickyNoteMeta - Remove unnecessary export from getPageUid (internal-only) - Defer title font measurement until after DOM insertion - Drop unused order field from StickyNoteRecord return type
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits the monolithic index.ts into focused modules (constants, layout store, Roam API) and addresses review findings: