Skip to content

Modularize sticky notes and fix code review findings#3

Open
salmonumbrella wants to merge 2 commits intoRoamJS:mainfrom
salmonumbrella:refactor/code-review-fixes
Open

Modularize sticky notes and fix code review findings#3
salmonumbrella wants to merge 2 commits intoRoamJS:mainfrom
salmonumbrella:refactor/code-review-fixes

Conversation

@salmonumbrella
Copy link
Copy Markdown

Splits the monolithic index.ts into focused modules (constants, layout store, Roam API) and addresses review findings:

  • Extract constants, layout persistence, and Roam API helpers into separate files
  • Replace N+1 startup queries with single Datalog query
  • Batch DOM appends with DocumentFragment
  • Defer title font measurement until after DOM insertion
  • Drop unused fields from internal API surface
  • Document intentional behavior changes

- Document intentional removal of startup database write in toStickyNoteMeta
- Remove unnecessary export from getPageUid (internal-only)
- Defer title font measurement until after DOM insertion
- Drop unused order field from StickyNoteRecord return type
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 17, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant