feat: configurable Archive hotkey, TODONT settings, and transition fixes#15
feat: configurable Archive hotkey, TODONT settings, and transition fixes#15salmonumbrella wants to merge 2 commits intoRoamJS:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ecb54e6 to
22bbaf1
Compare
|
@mdroidian done + Loom! Ready for you. |
Hi — thank you for putting this together. I appreciate the effort here. PRs that touch multiple concerns are significantly harder to review, and I have limited bandwidth right now. Following the guide helps ensure contributions can be reviewed and merged much more quickly. https://github.com/RoamJS/contributing/blob/main/contributing.md A couple adjustments are needed before this can move forward:
Once this is split up, I’ll be happy to take a look. |
|
Splitting this into 3 smaller, focused PRs per the contributing guidelines (one issue per PR, <500 lines each). The changes will be submitted as stacked PRs:
Each PR will be independently reviewable. The stacked approach ensures changes don't conflict since some fixes are prerequisites for others. |
Summary
TODO+ARCHIVEDonDonecallbacks via focusin/focusout tracking.closest()instead of fragile parent traversalsetTimeoutwrappers so block text is read after Roam processes state changesWhat was broken / missing?
TODO+ARCHIVEDprefix on Cmd/Ctrl+Enter instead of cleanly becoming TODO (Handle ARCHIVED => TODO #4)What changed?
src/index.ts: settings panel gains TODONT mode + hotkey fields, ARCHIVED→TODO normalization on Cmd/Ctrl+Enter, focusin/focusout tracking for DONE detection, proper unload cleanupsrc/utils/todont.ts: hotkey registration via Roam command palette instead of raw keydown, ARCHIVED button styling via CSS class instead of text replacement, extractedtodontCallbackfor reusesrc/utils/normalizeTodoArchivedPrefix.ts(new): regex helper to collapseTODO+ARCHIVEDintoTODOHow was it verified?
Manual testing in Roam.
video-for-github.mp4
Test plan
Closes #4, closes #8, closes #10.