Skip to content
This repository was archived by the owner on Mar 16, 2024. It is now read-only.

Conversation

@kberzinch
Copy link
Member

@kberzinch kberzinch commented Jul 5, 2021

This pull request makes several updates to the pipeline configuration to behave better on the new Concourse cluster.

Summary of changes:

  • Dockerfile accepts base image as a build arg - this allows the build step to use a local image fetched by Concourse, which can come from a cache instead of Docker Hub every time.
  • Tweaked wget calls to not output progress bars
  • Removed references to concourse-pipeline-library since you are not using it
  • Updated RoboJackets resource type usage to new pattern - build-specific data is provided as source/params instead of reading from git data every time
  • RoboJackets resource types now come from AWS ECR
  • Updated secret references to new locations
  • Simplified some shell scripts
  • Switched from docker-image to registry-image resource types everywhere - docker-image is deprecated by the Concourse team for various reasons and will be programmatically disallowed on the cluster at some point
  • Fixed some typos
  • Resources now have tag: [resource] to run on the resource-specific worker pool (this is a cost optimization that will be programmatically enforced at some point)
  • Switched to Docker build pipeline from the shared pipeline library because it was easier than updating this one

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 5, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kberzinch kberzinch marked this pull request as ready for review August 5, 2021 00:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants