feat: nostr forward notifications#2415
Open
keshav0479 wants to merge 10 commits intoRoboSats:mainfrom
Open
Conversation
Contributor
Author
|
Updated this after spending some more time testing the actual forwarding path. Fixed a few things that came up while checking it properly: Android settings updates were not sending I also tested it locally with strfry behind a temporary Tor hidden service, without Tor proxying the SDK could not connect to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2190
This adds Nostr forwarding for robot trade notifications.
The idea is that a user can keep using separate robot identities, but still receive encrypted order updates on their main Nostr key through their own
.onionrelay.What's included
ws://orwss://.onionrelaysPUTfixTesting
I tested the onion relay path locally with strfry behind a temporary Tor hidden service.
That caught one issue where the SDK could not connect to the
.onionrelay unless the forwarding client used the existing Tor proxy config. After that change, strfry accepted the forwarded event.Also ran:
manage.py test tests.test_api_robot_nostr_forwardmanage.py checkChecklist before merging
pip install pre-commit, thenpre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.