-
-
Notifications
You must be signed in to change notification settings - Fork 76
Full Rebuild (Sync) November 2025: bump ros-distro-mutex to 0.7.0 and build_number to 24 #557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Id like to help! :) |
I gave you access to the fork, feel free to push directly there in the |
|
Thanks! I pushed a number of (mostly windows) related fixes. Will continue later. |
The upstream source at release/noetic/rosbag/1.17.4-1 now uses conditional compilation (#if BOOST_VERSION < 107200) for boost headers.
|
I just tried to fix rosbash but it looks like the zsh implementation has changed quite a bit. I let my AI assistant cobble something together but I dont really trust it enough. |
|
Should we try to use |
The upstream source already removed add_compile_options(-std=c++11). Regenerated patch to only add OpenCV find_package and linking.
The upstream source at release/noetic/rosgraph/1.17.4-1 already has Python 3.11+ compatibility handling with conditional logic.
The upstream source at release/noetic/rospack/2.6.4-1 already handles APPLE-specific library exclusion using a package_libraries variable.
The upstream source already has the boost filesystem API updates (fs::extension). Regenerated patch without those already-applied changes.
The upstream source at release/noetic/topic_tools/1.17.4-1 already includes the <thread> header that this patch was adding.
The upstream source at release/noetic/tf2_py/0.7.10-1 already includes the APPLE-specific Python linking and -undefined dynamic_lookup flags.
The upstream source at release/noetic/tf/1.13.4-1 already removed the C++11 checking logic. Regenerated patch with only NO_ERROR and sys/time.h changes.
Done in traversaro@596aa7a . |
|
I can have a look at the zsh patch on Monday, but I am also fine with just removing it. |
Refactor run_rattler_build to run recipes individually and report results. Better for debugging.
|
Linux error: |
|
Windows error: |
|
osx error: |
|
Ah, sorry I forgot an important thing: the newly merged |
|
Windows error: |
|
Linux error due to conda-forge/gazebo-feedstock#245 |
Comment out package find commands in CMakeLists.txt
Comment out C++ standard and compiler options.
Removed C++ standard and compiler warning options from CMakeLists.txt.
Remove C++11 standard flag from CMakeLists.txt
|
@traversaro - I have a feeling we've seen this Windows error before somewhere, but I can't recall the fix. Can you remember? |
|
On linux, we're running into I think we have to move everything (qt-gui-cpp, rviz, ...) to qt6, which will be a major pain. Any ideas / volunteers? |
|
And I think for qt6, we're still missing conda-forge/pyqt-feedstock#145 |
|
We might want to check ros-visualization/python_qt_binding#143 and ros-visualization/qt_gui_core#293 |
The main goal here is to align noetic with the rest of the repos, switching to a unified
vinca.yamland similar. To be honest, I do not have any interested in Noetic packages it self at the moment, so if anyone more interested in Noetic wants to help here it would be great.fyi @mmoerdijk @TedVanderfeen @ruben-arts @baszalmstra @vmehta-humanoid @nmarticorena @daenny (just tagging the author of recent PRs to the Noetic repo)