Skip to content

Conversation

@beasleyjonm
Copy link
Contributor

@beasleyjonm beasleyjonm commented Oct 25, 2024

Each indication path in drugmechdb describes the COP for a drug-disease indication pair, but the "treats" edge is not explicitly included. I edited the parser to introduce these as "biolink:treats" edges.

@eKathleenCarter eKathleenCarter linked an issue Oct 28, 2024 that may be closed by this pull request
@eKathleenCarter
Copy link
Contributor

Looks like this needs a refactor.

@eKathleenCarter eKathleenCarter added the Refactor Parser needs refactoring and revision label Oct 28, 2024
@eKathleenCarter eKathleenCarter self-assigned this Oct 28, 2024
@eKathleenCarter
Copy link
Contributor

Given the "treats"/"ameliorates" edge refactor, I hesitate to approve this PR. I suggest we look at it more before merging it into main.

@eKathleenCarter eKathleenCarter added the Biological Context QC Require validation of biological context to ensure accuracy and consistency label Oct 28, 2024
@beasleyjonm
Copy link
Contributor Author

From the DrugMechDB paper: "DrugMechDB was constructed considering drug-disease indications from the DrugCentral
database, using the version downloaded on September 18, 2020"

So each drug-disease pair in each path in the source file could be considered an indication, at least as of 2020.

@eKathleenCarter
Copy link
Contributor

@beasleyjonm, how about we use the biolink:treats_or_applied_or_studied_to_treat for now until we can dig in to this some more?

@beasleyjonm
Copy link
Contributor Author

@beasleyjonm, how about we use the biolink:treats_or_applied_or_studied_to_treat for now until we can dig in to this some more?

Let's do that, since it's not clear that they update this regularly with latest indications on drug central and they state they used the 2020 version. It's possible some of the indications could have changed since then, so "treats_or_applied_or_studied_to_treat" seems the safest option.

Copy link
Contributor

@eKathleenCarter eKathleenCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Biological Context QC Require validation of biological context to ensure accuracy and consistency Refactor Parser needs refactoring and revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

code improvement for DrugMechDB

3 participants