Fixed the compatibility issue with Arduino IOT Cloud#68
Open
kindofn0pe wants to merge 7 commits intoRobotDynOfficial:masterfrom
Open
Fixed the compatibility issue with Arduino IOT Cloud#68kindofn0pe wants to merge 7 commits intoRobotDynOfficial:masterfrom
kindofn0pe wants to merge 7 commits intoRobotDynOfficial:masterfrom
Conversation
Fixed the compatibility issue with Arduino IOT Cloud
gb-123-git
added a commit
to gb-123-git/RBDDimmer
that referenced
this pull request
Oct 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I came across this situation where I had to use the dimmer with iot cloud and noticed that there is a minor issue regarding the ON_OFF typedef. I just renamed the ON/OFF states to RBD_ON/RBD_OFF everywhere was required and changed the english readme.
Regards