Create libbot2 deb packages for noble#25
Conversation
f15cc68 to
ee769f3
Compare
|
@jwnimmer-tri This pr should now have the fixes requested from #24 |
jwnimmer-tri
left a comment
There was a problem hiding this comment.
Reviewed 31 of 31 files at r1, all commit messages.
Reviewable status: 3 unresolved discussions, LGTM missing from assignee jwnimmer-tri, platform LGTM missing (waiting on @Aiden2244)
a discussion (no related file):
CAVEAT: In order for the script to run successfully, ...
This should be in a README file for posterity (not the PR overview).
a discussion (no related file):
From the PR overview ...
Removed logic that uploaded packages to Kitware wheel site
I agree that we want that outcome, but I didn't see any relevant code-deletions in the PR? Maybe I missed it?
README.md line 3 at r1 (raw file):
# RobotLocomotion Fork of libbot2 
BTW Since we are deleting all of CI, we should also delete all of the badge references in all of the READMEs.
ee769f3 to
3ccabe6
Compare
Aiden2244
left a comment
There was a problem hiding this comment.
Reviewable status: 2 unresolved discussions, LGTM missing from assignee jwnimmer-tri, platform LGTM missing (waiting on @jwnimmer-tri)
a discussion (no related file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
From the PR overview ...
Removed logic that uploaded packages to Kitware wheel site
I agree that we want that outcome, but I didn't see any relevant code-deletions in the PR? Maybe I missed it?
Oops, not sure how that moved from the to-do list to the changelog without any requisite changes 🤦 . Come to think of it, unless I am missing something, I can't actually find any code that uploads these packages anywhere. There is logic in the scripts/setup/.../install_prereqs.sh file which designates that Kitware packages are installed from the Kitware apt site instead of the standard Ubuntu site; should this logic go away? AFAIK this is strictly for configuration purposes, but if it references a configuration or a repo that is out of date then it should probably go.
a discussion (no related file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
CAVEAT: In order for the script to run successfully, ...
This should be in a README file for posterity (not the PR overview).
I added this in a README in the same directory as the script itself, but can move it elsewhere if we think that would be clearer.
jwnimmer-tri
left a comment
There was a problem hiding this comment.
Reviewed 9 of 9 files at r2, all commit messages.
Reviewable status: all discussions resolved, LGTM missing from assignee jwnimmer-tri, platform LGTM missing (waiting on @Aiden2244)
a discussion (no related file):
I can't actually find any code that uploads these packages anywhere.
Not surprising. I imagine it was done by hand previously.
... which designates that Kitware packages are installed from the Kitware apt site instead of the standard Ubuntu site; should this logic go away?
Let's keep it for now. That's providing a first-party CMake instead of Ubuntu's package. I might circle back and switch to Ubuntu CMake later, but we'll leave it alone for now.
Closes Drake issue #22891
Updated the libbot2 packaging script from the
drakebranch to create thelcmandlibbot2packages from source targeting Ubuntu 24.04 (noble). To verify correctness, the script was executed on an amd64 machine running Ubuntu 24.04. The script successfully created.debpackages forlcmandlibbot2, both of which could be manually installed on the host machine. After installation, the program/opt/libbot2/<version>/bin/bot-procman-sheriffran successfully and was able to recognize when an/opt/libbot2/<version>/bin/bot-procman-deputyprocess was launched.CAVEAT: In order for the script to run successfully, the directory where the packages are installed (which is the root directory of the clone, by default) needs to have global write permissions enabled (via
chmod a+w </path/to/root>).Summary of key changes:
CMakefrom3.1to3.5scripts/package/linux/ubuntu/common/build.shin order to build LCMCMakefrom3.1to3.10Py_TYPEwith calls toPy_SET_TYPEto reflect API upgradefreeglut3tolibglut3.12and cousins to reflect upgraded package namingnoblenobleRemoved logic that uploaded packages to Kitware wheel siteThis change is