Support fixed-based robots#17
Merged
cmastalli merged 12 commits intoRobotMotorIntelligence:develfrom Apr 4, 2024
Merged
Conversation
Collaborator
Author
|
The rolling unit tests are broken. Let's ignore them in this PR and yours @Sergim96! Btw, the PR is ready to be reviewed! Please have a look! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before merging #16, we need to include these changes are rebased. Unfortunately, I forgot to merge this work and it seems we need to include these changes into the other PR.
I'll work on extending our unit tests to check for fixed-based systems.
@Sergim96 -- please review this code and later rebase your branch. Apologies for the inconvenience.